search

goreleaser / nfpm

nFPM is Not FPM - a simple deb, rpm, apk, ipk, and arch linux packager written in Go
https://nfpm.goreleaser.com/
MIT License
2.14k stars 156 forks source link

fix(rpm): conventionalfilename #715

Closed caarlos0 closed 11 months ago

caarlos0 commented 11 months ago

formatVersion is also used to set the version field of the RPM, which should not contain the release.

this fixes it, and the tests which were wrong.

closes #714

cloudflare-pages[bot] commented 11 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9291134
Status:⚡️  Build in progress...

View logs

codecov[bot] commented 11 months ago

Codecov Report

Merging #715 (ef22085) into main (761c574) will increase coverage by 0.06%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

:exclamation: Current head ef22085 differs from pull request most recent head 9291134. Consider uploading reports for the commit 9291134 to get more accurate results

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
+ Coverage   75.02%   75.08%   +0.06%     
==========================================
  Files          10       10              
  Lines        2406     2412       +6     
==========================================
+ Hits         1805     1811       +6     
  Misses        425      425              
  Partials      176      176
Files Changed Coverage Δ
rpm/rpm.go 71.42% <100.00%> (+0.61%) :arrow_up: