Closed schmidtw closed 5 months ago
Attention: Patch coverage is 75.00000%
with 64 lines
in your changes are missing coverage. Please review.
Project coverage is 72.65%. Comparing base (
409b516
) to head (2210695
). Report is 4 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
ipk/ipk.go | 86.88% | 13 Missing and 11 partials :warning: |
ipk/tar.go | 58.49% | 11 Missing and 11 partials :warning: |
nfpm.go | 15.38% | 10 Missing and 1 partial :warning: |
internal/cmd/package.go | 0.00% | 4 Missing :warning: |
internal/cmd/root.go | 0.00% | 2 Missing :warning: |
cmd/nfpm/main.go | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@caarlos0 any feedback?
sorry, haven't had the time to look into it yet... will probably review over the weekend.
at first glance, it does look good though!
also, thanks for the PR 🙏🏻
it looks awesome, thanks!
and sorry for the delay reviewing it!
Implements #507.