gorghoa / ScenarioStateBehatExtension

Provide a way to share scenario state through steps
MIT License
33 stars 7 forks source link

Autoload ScenarioStateArgument upon extension initialisation #20

Closed walterdolce closed 7 years ago

walterdolce commented 7 years ago

This should fix #19

gorghoa commented 7 years ago

Hi @walterdolce, thanks for your feedback and PR, we really appreciate your help !

Even if all tests are green, we’ll need to try on a real symfony project to validate it does not break a thing.

walterdolce commented 7 years ago

@gorghoa you're welcome!

Even if all tests are green, we’ll need to try on a real symfony project to validate it does not break a thing.

Why would it? It's just a behat extension. But sure, please run your checks..

vincentchalamon commented 7 years ago

@walterdolce I actually run this extension on multiple Symfony-standard-edition projects without any problem, so it means it's automatically registered by the project. I just want to be sure it won't break other projects by double-loading this annotation 😉

vincentchalamon commented 7 years ago

@walterdolce I guess your project is not a Symfony standard edition? How do you load other annotations in your project?

walterdolce commented 7 years ago

I guess your project is not a Symfony standard edition? How do you load other annotations in your project?

My project is not a Symfony project at all :-) No other annotations loaded. Just the one provided by the extension.

vincentchalamon commented 7 years ago

@walterdolce OK thanks, we're checking on Symfony projects and be back in a few minutes :-)

walterdolce commented 7 years ago

vincentchalamon commented 7 years ago

Thanks @walterdolce