[RFR] Inject store arguments in Behat hooks non step methods

gorghoa / ScenarioStateBehatExtension

Provide a way to share scenario state through steps

MIT License

33 stars 7 forks source link

[RFR] Inject store arguments in Behat hooks non step methods #24

Closed vincentchalamon closed 7 years ago

vincentchalamon commented 7 years ago

Fix #23

vincentchalamon commented 7 years ago

Unit tests in progress…

vincentchalamon commented 7 years ago

Scrutinizer patches are wrong: http://www.php-fig.org/psr/psr-2/#closures Some Scrutinizer issues are wrong (duplicate code, PHPUnit mocks), but the other issues should be fixed in another PR (https://goo.gl/cA4uEC)

gorghoa commented 7 years ago

@meyerbaptiste, ok for you?

gorghoa commented 7 years ago

@gregcop1, If you have some time to spend, could you verify that the PR fixes your use case? (If not, just trust @vincentchalamon’s work and everything will be fine I’m sure)

gorghoa commented 7 years ago

Note. I’m okay with the small BC breaks due to namespace reorganization (the Exception chiefly).

I suggest to ship it to minor version anymay, even if it conflicts with semver. I expect no one will feel the pain since it’s deeply internal subject and the user base is still small ;)