search

gorghoa / ScenarioStateBehatExtension

Provide a way to share scenario state through steps
MIT License
33 stars 7 forks source link

SF5 Compatibility #38

Closed magarzon closed 3 years ago

magarzon commented 3 years ago

Added SF5 compatibility

gorghoa commented 3 years ago

Thanks @magarzon :+1:

@vincentchalamon, builds failed on php5.5 and 5.6. I think we could allow them to fail, what do you think (see #39) ?

@magarzon, have you actually successfully run it with symfony 5 ?

gorghoa commented 3 years ago

Builds for #39 are not passing yet, but I am comfortable with your PR being merged now @magarzon.

Can you just allow php 5.5 and 5.6 to fail in .travis.yml ?

I’m open to divergent opinions though :-°

magarzon commented 3 years ago

Thanks @magarzon

@vincentchalamon, builds failed on php5.5 and 5.6. I think we could allow them to fail, what do you think (see #39) ?

@magarzon, have you actually successfully run it with symfony 5 ?

Yes, I have tested in SF5 and it works.

gorghoa commented 3 years ago

thanks @magarzon :+1:, v1.0.7 tagged