search

gorghoa / ScenarioStateBehatExtension

Provide a way to share scenario state through steps
MIT License
33 stars 7 forks source link

php version >=7.0 #39

Open gorghoa opened 3 years ago

gorghoa commented 3 years ago

Set minimum php version to 7.0.

Builds on php 5 are failing and I don’t see the point to take time to maintain them.

gorghoa commented 3 years ago

ref #38

vincentchalamon commented 3 years ago

LGTM

gorghoa commented 3 years ago

So, which php 7 lowest version shall we support?

Regarding https://www.php.net/supported-versions.php:

image

I would personally be comfortable to require at least php 7.2 (eventually php 7.3 since php 7.2 will stop being supported within a month)

vincentchalamon commented 3 years ago

I would be personally comfortable to require at least php 7.2 (eventually php 7.3 since php 7.2 will stop being supported within a month)

Agree with 7.2 :+1: