search

gorghoa / ScenarioStateBehatExtension

Provide a way to share scenario state through steps
MIT License
33 stars 7 forks source link

Allow php5 to fail #40

Closed gorghoa closed 4 years ago

gorghoa commented 4 years ago

Travis’ builds are failing on php5, blocking some useful PR.

Allowing them to fail.

vincentchalamon commented 4 years ago

Duplicate from https://github.com/gorghoa/ScenarioStateBehatExtension/pull/39

gorghoa commented 4 years ago

@vincentchalamon, I agree with the objective.

The difference with #39 is that this PR does not imply major version change (no BC break), just fix a CI failure. #39 will imply a major version bump.

I just want to be able to merge #38 without @magarzon to suffer a build failure.

vincentchalamon commented 4 years ago

Removing PHP5 from the CI is not a BC break. I would better just remove PHP5 from the CI, but not from the composer.json

gorghoa commented 4 years ago

Nope, but #39 will require a php version >= 7.x (in composer.json), hence requiring a major version bump IMO

Removing PHP5 from the CI is not a BC break. I would better just remove PHP5 from the CI, but not from the composer.json

That’s the point. I want to tag a minor release version compatible with php5.6 and allowing symfony 5

Then, I want to tag a new major version requiring a more recent php version, dropping all unsupported php version.tests.

gorghoa commented 4 years ago

thanks :)