search

gorgonia / tensor

package tensor provides efficient and generic n-dimensional arrays in Go that are useful for machine learning and deep learning purposes
Apache License 2.0
362 stars 49 forks source link

Upgrade assume-no-moving-gc to the latest version. #128

Open wipsel opened 2 years ago

wipsel commented 2 years ago

Hi

We have been using this package in some of our projects. It has been working great so far. Since go 1.18 we have a panic caused by assume-no-moving-gc. This can be fixed by setting the env var : ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.18

I updated the version in go.mod and it looks like everything is working. I don't know if this has any other implications. But Would be nice to get rid of the panic and update the package to go 1.18?

I'll try to create a pull request with the changes.

wipsel commented 1 year ago

Hi again

Since the last version 3 new go versions have been released. I was wondering why go4.org/unsafe/assume-no-moving-gc is imported and if we could get rid of it in the future so that we won't need update it every time the go runtime is updated.

chewxy commented 1 year ago

Arghhhhh! I thought I updated this. I even tweeted about updating this!! I need to go find the machine where I made the change, as I suspect I didn't make a push.

pdevine commented 9 months ago

I just ran into this problem. Any chance for a fix?

pdevine commented 8 months ago

I ended up just forking the repo into pdevine/tensor and patching that to not through the error. I'll kill that fork if this ever gets updated.