Fix a bug where axes in the along array were only ever decremented by…

gorgonia / tensor

package tensor provides efficient and generic n-dimensional arrays in Go that are useful for machine learning and deep learning purposes

Apache License 2.0

359 stars 49 forks source link

Fix a bug where axes in the along array were only ever decremented by… #48

Closed bdleitner closed 4 years ago

bdleitner commented 4 years ago

… 1 to account for prior reductions, no matter how many reductions had occurred.

Factor out common code for the Max, Min, and Sum reductions.
Include tests for 4D tensors for complete as well as partial reduction across all 3 reduction methods.

Closes #47

coveralls commented 4 years ago

Coverage decreased (-0.02%) to 72.825% when pulling bdbfd6daf4098d0693db579f41b027169bf52b2e on bdleitner:fix-47-reduction into ed6f879a2501b99b0f488fc050097c9c48107964 on gorgonia:master.

chewxy commented 4 years ago

@bdleitner is this ready for merge (also can you please email me: chewxy [at] gmail thanks)

bdleitner commented 4 years ago

@bdleitner is this ready for merge (also can you please email me: chewxy [at] gmail thanks)

Yes, it's ready. A followup. Since the fix I'm working on for https://github.com/gorgonia/gorgonia/issues/326 depends on this, but they are in separate repos, does there need to be a release for the tensor package for the gorgonia repo to see it? If so, what's the timeline for such things?

chewxy commented 4 years ago

I will arrange for a release immediately post merge