search

gorhill / httpswitchboard

Point & click to forbid/allow any class of requests made by your browser. Use it to block scripts, iframes, ads, facebook, etc.
GNU General Public License v3.0
1.33k stars 83 forks source link

Element hiding rules not shown in statistics #284

Open ghost opened 10 years ago

ghost commented 10 years ago

Whenever element hiding rules are applied, I can't see corresponding entries in the statistics tab. The ABP icon in the matrix doesn't show them, either.

gorhill commented 10 years ago

I don't see this as very useful, given that element hiding has nothing to do with net requests (the primary purpose of HTTPSB). It's purely cosmetic, while all current stats are really related to net requests.

With the (required) optimizations I put in yesterday regarding ABP cosmetic filtering, the VIM test shows that memory consumption has gone up (because the speed optimization required using more memory content script-side). Still largely under ABP's memory footprint, but my goal was to bring it down further, not up, and this feature here would push the memory footprint for that stress test up another notch.

ghost commented 10 years ago

I understand your concerns. On the other hand, if those rules break some sites (hopefully very rarely) that would be hard to spot if the user can't even see that they are triggered at all.

gorhill commented 10 years ago

Ok I will keep this in mind, probably the overhead is not that terrible. When I get time I will try various ideas I get when thinking about such an issue. I think I would report it only in the tool tip of the icon though, this is where that would be mostly useful.