search

gorhill / uBO-Extra

A companion extension to uBlock Origin
GNU General Public License v3.0
653 stars 42 forks source link

Add Greasemonkey manifest #107

Closed tbodt closed 5 years ago

tbodt commented 5 years ago

This allows installing uBO-Extra on browsers that aren't Chrome (I use it with Safari.)

Note that the @version field will need to be updated when a new version is released, in addition to the version in manifest.json.

jspenguin2017 commented 5 years ago

You'll be losing race conditions if you make it into an Userscript.

tbodt commented 5 years ago

Userscripts can be run before the DOM is loaded in the same fashion as content scripts. I've updated the manifest to do this.

jspenguin2017 commented 5 years ago

If the Userscript manager is a WebExtension, then that's not possible. Even if you put document-start, you'll still lose race condition. Otherwise, uBO-Extra wouldn't exist.

tbodt commented 5 years ago

What's the difference between a content script running at document start and a userscript running at document start?

gorhill commented 5 years ago

If I accept this pull request (assuming it worked as intended), it implies that I will accept to widen its purpose and also maintain it as a user script, which is not something I ever intended to do or want to do.

jspenguin2017 commented 5 years ago

Userscript can't run on the true document-start.

gorhill commented 5 years ago

Declined.