search

gorhill / uBO-Extra

A companion extension to uBlock Origin
GNU General Public License v3.0
650 stars 42 forks source link

new site with "g00" behavior #111

Closed Procyon-b closed 5 years ago

Procyon-b commented 5 years ago

I've encountered a new site with the same behavior as msn: page load interrupted -> reloading using g00 urls. I've fixed it by disallowing one script, but I don't know if it breaks others things on this site. I don't know if it should be fixed with a filter in one of the standard filters lists, or if uBO extra is the solution.

https://www.narcity.com/ca/qc/montreal/lifestyle/harry-potter-et-leducation-sexuelle-une-parodie-de-sarah-jeanne-labrosse-et-pier-luc-funk-a-mourir-de-rire

Note about the msn example: Until recently I was using an old version of uBO, more specificaly, a clone/fork (until 2018/11/13), and discovered the "g00" behavior only after installing the lastest uBO (version 1.17). I have downloaded and installed older version of uBO, and discovered that msn uses "g00" only with uBO version >=1.16. v1.15.24 and lower doesn't trigger the behavior (and so, no backdoor used to load ads).

Do you want me to file a new issue in uBO (or here) with all the infos to reproduce the test?

mapx- commented 5 years ago

Could you test this filter narcity.com##+js(abort-on-property-read.js, I10C)

okiehsch commented 5 years ago

Works on my end.

okiehsch commented 5 years ago

Note about the msn example: Until recently I was using an old version of uBO, more specificaly, a clone/fork (until 2018/11/13), and discovered the "g00" behavior only after installing the lastest uBO (version 1.17). I have downloaded and installed older version of uBO, and discovered that msn uses "g00" only with uBO version >=1.16. v1.15.24 and lower doesn't trigger the behavior (and so, no backdoor used to load ads).

I am not sure there is something gorhill can do about that, but I reopened because I missed that part of the issue.

Procyon-b commented 5 years ago

FYI I'm currently using this filter: https://www.narcity.com/assets/

okiehsch commented 5 years ago

If you update your uBO-filters list you can remove that filter

Procyon-b commented 5 years ago

It's fixed with uBO-filters reloaded. Is that somehing you've fixed just now?

okiehsch commented 5 years ago

image

Procyon-b commented 5 years ago

That was fast :)

Edit: I missed the reference, sorry

gorhill commented 5 years ago

discovered that msn uses "g00" only with uBO version >=1.16. v1.15.24 and lower doesn't trigger the behavior

It can be quite time consuming to investigate IL stuff, so without investigating I can only speculate. The change that stands out in 1.16.0 is that uBO started to use user stylesheets in 1.16.0, which suggests that IL was using uBO's injected stylesheet in the DOM to decide whether or not it activated itself.

terrorist96 commented 5 years ago

I confirm that I see ads at that link. image

terrorist96 commented 5 years ago

@okiehsch thanks, fixed on my end. Can this be closed?