gorhill / uBO-Extra

A companion extension to uBlock Origin
GNU General Public License v3.0
653 stars 42 forks source link

Report of it blocking the BookTrakr Button #125

Open jackrg opened 4 years ago

jackrg commented 4 years ago

The BookTrakr Button is a browser extension that automates the user's Amazon/Kindle Direct Publish website to generate and upload reports to our website for analysis and inclusion in the user's dataset. With uBO-Extra enabled, they ciick a browser button that starts the automation, which opens a new window, and attempts to navigate to the Amazon login page so that the user can login to their KDP account (we do nothing else until the user submits the login form and a new page loads. What is actually happening is that the new window opens and then ... nothing.

Originally, there was a message on the screen (ERR_BLOCKED_BY_CLIENT) when we tried to load the Amazon page. That was handled by configuring the ad blocker to let BookTrakr open Amazon pages. But then this error occurred, and the user discovered that they could get the problem to go away if they disabled uBO-Extra.

Please let me know what you might need in the way of further explanation, screen shots, etc. and I'll provide what I can (I can't promise that I can get additional screen shots from my user but I'll try).

liamengland1 commented 4 years ago

Are you sure this isn't a problem with uBlock Origin? uBo-extra does not block requests and has no effect on amazon.com.

jackrg commented 4 years ago

TBH, I’m not sure about anything. This is one customer who first reported the ERR_BLOCKED_BY_CLIENT which was resolved by disabling the ad blocker on amazon.com http://amazon.com/ and booktrakr.com http://booktrakr.com/. Then after getting a good result, they found that the Button hung the next time they tried it, at which point they disabled uBo-extra, and the Button ran successfully. This is not at all definitive, as many users get this problem and don’t have uBo-extra installed. I will say overall that this is not a thoroughly reproducible problem. I’m reporting this, while not knowing that much about uBo-extra, on the following basis:

1) I am hopeful that the description of the problem will spark something in the developers that cause them to say “Oh, that’s <fill in explanation here>. Just do this: <fill in solution>.
2) The developers can say “check this, that, and the other, and get back to us with your results.

I’m not so naive that I’ll be shocked if I don’t get one of these two outcomes. But I really don’t know how to proceed to determine what’s going on here. I’ve checked the JS console to see if there are any messages there, and of course there are none (other than the ERR_BLOCKED_BY_CLIENT). Further, the problem appears to be intermittent (I’ve had it occur once or twice on my system, but it’s not at all reproducible on demand). And of course I’ve verified that all of my Promise chains have a .catch handler to report the problem (obviously, that’s not the only thing that can go wrong, but in my experience that is the most likely issue that could cause a quiet failure).

Thanks for your consideration.

Jack

On May 6, 2020, at 7:13 PM, LE notifications@github.com wrote:

Are you sure this isn't a problem with uBlock Origin? uBo-extra does not block requests and has no effect on amazon.com.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gorhill/uBO-Extra/issues/125#issuecomment-624988435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHK5AKBFBW6Z6SGWLGWIKTRQIKNVANCNFSM4M25XLYQ.

gorhill commented 4 years ago

I doubt it's uBO-Extra, as noted by @llacb47, it does not block requests, and it's doing something only on a limited set of sites.

From what I understand, it's a filter issue, not an issue with uBO itself. To solve such issue, we need repro steps so we can identify which filter is interfering with the proper functioning of your extension.

I gather that your extension is causing network requests to be made in the context of a web page, otherwise uBO would not be able to block it.

There are a number of amazon. filters in EasyPrivacy that are meant to apply on all sites, so it could be one of them, but then again, we need repro steps.

jackrg commented 4 years ago

Thanks for the quick response. What you say makes sense; I’m just reporting what a customer told me. I looked over the EasyPrivacy filter list and it doesn’t look like there’s anything in there that should affect us, so I’m going to assume that’s a non-starter as well. The biggest problem is that I’m not getting an error message when this happens, so it’s difficult to determine exactly where the problem is. I now know what I need to know from you, and you won’t hear back from me until and unless I have a reproducible case that points at uBo or uBo-extra.

Thanks for your time.

Regards,

Jack

On May 7, 2020, at 3:42 AM, Raymond Hill notifications@github.com wrote:

I doubt it's uBO-Extra, as noted by @llacb47 https://github.com/llacb47, it does not block requests, and it's doing something only on a limited set of sites https://github.com/gorhill/uBO-Extra/wiki/Sites-on-which-uBO-Extra-is-useful.

From what I understand, it's a filter issue, not an issue with uBO itself. To solve such issue, we need repro steps so we can identify which filter is interfering with the proper functioning of your extension.

I gather that your extension is causing network requests to be made in the context of a web page, otherwise uBO would not be able to block it.

There are a number of amazon. filters in EasyPrivacy that are meant to apply on all sites, so it could be one of them, but then again, we need repro steps.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gorhill/uBO-Extra/issues/125#issuecomment-625175629, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHK5AKJSOMU65QNTR2E34LRQKGBHANCNFSM4M25XLYQ.

gorhill commented 4 years ago

biggest problem is that I’m not getting an error message when this happens, so it’s difficult to determine exactly where the problem is

If you can reproduce on your side or have someone who can reproduce, then you/they can just look at uBO's logger, this will tell you what is blocked by which filter from which filter list.

jackrg commented 4 years ago

That’s excellent. I will definitely use that in troubleshooting this issue.

Thanks again.

On May 7, 2020, at 6:10 PM, Raymond Hill notifications@github.com wrote:

biggest problem is that I’m not getting an error message when this happens, so it’s difficult to determine exactly where the problem is

If you can reproduce on your side or have someone who can reproduce, then you/they can just look at uBO's logger https://github.com/gorhill/uBlock/wiki/The-logger, this will tell you what is blocked by which filter from which filter list.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gorhill/uBO-Extra/issues/125#issuecomment-625574482, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHK5AKI7BSHUMKIAJEX3Q3RQNLYHANCNFSM4M25XLYQ.