search

gorhill / uBO-Extra

A companion extension to uBlock Origin
GNU General Public License v3.0
654 stars 42 forks source link

uMatrix causes error with Google Hangouts regardless of whether uBlock/uMatrix is enabled #15

Closed argiopetech closed 7 years ago

argiopetech commented 7 years ago

Not sure when this became an issue, but it's definitely present in 2.4. On attempting a call through https://hangouts.gooogle.com (just pressing "Video Call" button is sufficient), Chrome notes, "Error - Sorry, we encountered a problem joining this video call". The console shows:

(3) WebSocket connection to 'wss://hangouts.google.com/' failed: WebSocket is closed before the connection is established.

This issue occurs only when uBO-Extra is enabled, never when it is disabled. The status of uBlock and uMatrix is irrelevant, i.e., uMatrix enabled with uBlock and uMatrix disabled still causes the issue to occur.

gorhill commented 7 years ago

The warning is normal given what uBO-Extra has to do, but I have checked with some other test cases found on the web that it did not cause an issue. I could reproduce the error, investigating.

gorhill commented 7 years ago

I can't figure what is the issue, as my breakpoints are not triggered. For now I will create exceptions for some of the scriptlets, and I added hangouts.google.com to the WebRTC wrapper.

ghost commented 7 years ago

Maybe add ipleak.net too so that one can test if WebRTC would leak IP addresses to Google Hangouts?

gorhill commented 7 years ago

ipleak.net works fine for me, it could detect my local IP address when I disabled the setting in uBO.

ghost commented 7 years ago

That's true, sorry. I must have not disabled it when I tested.

argiopetech commented 7 years ago

Thanks for your quick resolution, @gorhill!

okiehsch commented 7 years ago

https://webrtc.github.io/samples is also broken, seems to be the same issue, for example https://webrtc.github.io/samples/src/content/peerconnection/webaudio-input

  1. with uBO extra 2.3

webrtc

  1. with uBO extra 2.5

webrt

gorhill commented 7 years ago

Can you confirmed above is fixed on your side with 2.6?

okiehsch commented 7 years ago

Yes https://webrtc.github.io/samples is fixed with 2.6.