gorhill / uBO-Extra

A companion extension to uBlock Origin
GNU General Public License v3.0
653 stars 42 forks source link

MSN Issue #96

Open karelo911 opened 6 years ago

karelo911 commented 6 years ago

I'm trying to open this site: https://www.msn.com/en-ph/ It reloads itself once, then this certain g00 script with a long obfuscated name gets through. Here's a screenshot from uBlock log image

Currently using uBlock 1.16.12 and uBlock extra 2.74 on Windows 7 SP1 x86 PC running Slimjet Version 19.0.8.0 (based on Chromium 66.0.3359.117)

gorhill commented 6 years ago

Unable to reproduce, using Chromium 67.

karelo911 commented 6 years ago

I don't know what happened yesterday but it's gone for now. Thank you very much.

karelo911 commented 6 years ago

Oops. capture

karelo911 commented 6 years ago

So I added this line to my filters ||https://c-5uwzmx78pmca09x24iklvx2eilvfax2ekwu.g00.msn.com And the ad frame disappears. The page seems to be continuously requesting for ads though for the meantime the ads are gone.

gorhill commented 6 years ago

Would be useful to find out if others can reproduce as well with latest uBO-Extra installed.

okiehsch commented 6 years ago

I can't reproduce.

gorhill commented 6 years ago

@okiehsch Using Slimjet?

okiehsch commented 6 years ago

Oops, sorry I overlooked that, no using Chrome stable version.

gorhill commented 6 years ago

Could be an issue specific to Slimjet.

@karelo911, can you test with Chromium or Chrome?

devdistro commented 6 years ago

I have started seeing the ads now on many website defeating ublock extra Seeing how sneaky is IL they could be keeping an eye on these ublock pages and blacklisting the reported pages so as to make it difficult to troubleshoot by gorhill. They have huge revenue/reputation to defend

One example url (@gorhill Let me know if I should file a different issue): https://www.extremetech.com/internet/247808-new-perceptual-ad-blocker-may-impossible-websites-defeat

VernonStow commented 6 years ago

The MSN issue may be related to https://github.com/uBlockOrigin/uAssets/issues/3046

VernonStow commented 6 years ago

@devdistro, I don't see any ads on that page with Chromium 69.0.3496.0 (Official Build) (32-bit), uBO 1.16.14 and uBlock-Extra.

devdistro commented 6 years ago

@VernonStow Neither do I on my Macbook. Will try again from my windows machine and will report back. Current system: OS - Mac 10.13.3 Chrome - Version 67.0.3396.99 (Official Build) (64-bit)

kulfoon commented 6 years ago

Clean here: Opera 56.0.3051.52 64bit & uBO 1.17.2 (def + uBO annoyances) & uBO Extra 2.78

kulfoon commented 6 years ago

Weird, while trying to help with https://github.com/uBlockOrigin/uAssets/issues/3703 issue, I've been visiting the msn.com several times last hour, and there was no g00 thing in Firefox in uBO logger (only in Opera 56 with uBO Extra disabled, but once uBO Extra enabled, the g00 stuff is gone as I posted above in my previous comment), and just right now have encountered it in Firefox 63 64bit:

Logger screenshoots with g00 stuff ![ss4](https://user-images.githubusercontent.com/43844449/47864854-f1050280-ddfa-11e8-8cb6-db32ae801459.png) ![ss3](https://user-images.githubusercontent.com/43844449/47864852-f06c6c00-ddfa-11e8-82f0-f2638ed79f83.png) ![ss6](https://user-images.githubusercontent.com/43844449/47864856-f19d9900-ddfa-11e8-8a55-8a3da27a60fc.png) ![ss1](https://user-images.githubusercontent.com/43844449/47864850-f06c6c00-ddfa-11e8-9e3b-d5d13efddd0b.png)

.

The url is: https://www.msn.com/en-in?AR=1

As per https://github.com/gorhill/uBO-Extra/issues/96#issuecomment-406190594, as seen in my case the g00 stuff appears randomly too. And as per https://github.com/uBlockOrigin/uAssets/issues/227#issuecomment-325191273 I'm wondering if has the time come to make uBO Extra for Firefox.

VernonStow commented 6 years ago

@kulfoon I find that these filters remove much of the g00 stuff in Firefox Quantum:

www.msn.com##div.stripecontainer:nth-of-type(19) > .stripeouter.finance > .full-width.stripe www.msn.com##div.stripecontainer:nth-of-type(20) > .stripeouter.finance > .full-width.stripe www.msn.com##div.stripecontainer:nth-of-type(8)

ZaphodBeebblebrox commented 6 years ago

@kulfoon, uBlock Origin extra will likely not be needed for Firefox even if Instart Logic comes to Firefox because of HTML filters. The main thing that makes Instart Logic difficult to deal with is that we cannot simply abort their script, which HTML filters solve quite neatly.

kulfoon commented 6 years ago

ZaphodBeebblebrox right, I forgot about this fact.

VernonStow I can't even test them, coz when I've visited the website just right now, there is no g00 stuff served in Firefox anymore as for now, also as ZaphodBeebblebrox has mentioned, we most probably will need to use html filters anyway, I don't think that hiding rules can remove g00.

VernonStow commented 6 years ago

@kulfoon I use those filters just to hide the rows of "sponsored ads" that sometimes appear in between rows of normal content. I had been using a much larger filter set to block Instart Logic with uBO Legacy on Pale Moon, but those filters are no longer enough to make the page usable.

terrorist96 commented 5 years ago

Ads are showing for me and the page layout is broken. https://www.msn.com/g00/en-us/news/politics/red-flag-gun-control-bills-pick-up-momentum-with-gop-in-congress/ar-AAFqNjB and msn.com redirects to msn.com/g00 image

mapx- commented 5 years ago

for now add msn.com##+js(abort-on-property-write.js, Ka)

terrorist96 commented 5 years ago

for now add msn.com##+js(abort-on-property-write.js, Ka)

Thanks, that works. Just gotta manually remove the g00 from the URL bar (for already open pages; g00 won't appear with that filter for newly loaded pages). What's the reason that filter can't be merged?

mapx- commented 5 years ago

maybe it's not static, changing daily ? will see

terrorist96 commented 5 years ago

@mapx- MSN is redirecting to g00 again. Example: https://www.msn.com/en-us/news/us/macabre-video-of-fake-trump-shooting-media-and-critics-is-shown-at-his-resort/ar-AAIJ5Bm

liamengland1 commented 5 years ago

Update filters

terrorist96 commented 5 years ago

Update filters

Not fixed.

mapx- commented 5 years ago

try disabling uBo extra and test this filter (clear the cookies too) @@*$image,domain=msn.com

mapx- commented 5 years ago

or test - even keeping uBo extra enabled @@*?&ad_$image

mapx- commented 5 years ago

or *?&ad_$image,redirect-rule=1x1.gif

terrorist96 commented 5 years ago

All three suggestions work. Thanks!