search

gorhill / uBlock-for-firefox-legacy

uBlock Origin for Firefox legacy-based browsers.
GNU General Public License v3.0
201 stars 23 forks source link

Add support for entity-matching in `domain=` filter option #236

Open THEtomaso opened 4 years ago

THEtomaso commented 4 years ago

When these type of rules starts to appear, it's important that uBO Legacy supports them!: https://github.com/gorhill/uBlock/commit/3c67d2b89f8ac6d680e74af3e11b916889f7/

THEtomaso commented 4 years ago

@hawkeye116477:

Your thoughts on this.. Is it something that you would consider looking into?

uBlock filters already contains some rules now, which depends on this feature. When their big filter revision process takes place, uBO Legacy will be severely crippled, unless it supports those type of syntaxes!

--

EDIT: I rewrote the current incompatible rules for uBO's Legacy filter: https://github.com/uBlockOrigin/uAssets/commit/db8e32588e4605d8a835cef0cc696c56f78e96fb/ ..but of course, this isn't a long-term solution.

hawkeye116477 commented 4 years ago

@THEtomaso I won't promise nothing, but maybe. You don't need to shout, I hear you...

THEtomaso commented 4 years ago

"Shouting" means writing everything in capital letters. I never do that. :)

THEtomaso commented 4 years ago

I just rewrote more domain=.* entries for uBO's Legacy filter. At the moment, I think everything is covered, but this syntax is commonly used now, so I don't know for how long I will be able to keep up.

If anyone wants to help out, here's how: 1 - Search up the domain=.* entries in uBO Filters, using this parameter: /domain=.*\*/ 2 - Make sure that the rules haven't already been rewritten for uBO's Legacy filter. 3 - Look up the .* domains (excluding .*) at https://instantdomainsearch.com/domain/extensions/ 4 - Rewrite the rules, covering all of the taken TLDs (marked in red). 5 - Post the rewritten rules here: https://github.com/uBlockOrigin/uAssets/commit/db8e32588e4605d8a835cef0cc696c56f78e96fb/