gorhill / uBlock-for-firefox-legacy

uBlock Origin for Firefox legacy-based browsers.
GNU General Public License v3.0
201 stars 24 forks source link

Input fields looks inconsistent on dark GTK themes #302

Open hawkeye116477 opened 3 years ago

hawkeye116477 commented 3 years ago

Prerequisites

Description

Input fields and select menus looks inconsistent with uBO theme, when dark GTK theme is enabled.

2021-04-10_18-48

2021-04-10_18-49

I think that's the best solution currently:

input, select {
    color: var(--default-ink);
    background-color: var(--default-surface);
}

It's not ideal, cuz arrows on input field number and select menus still will be dark.

Mozilla fixed that in https://bugzilla.mozilla.org/show_bug.cgi?id=1527048 for webpages and out of process webextensions.

Maybe even better solution would be to make dark mode for uBO .

A specific URL where the issue occurs

chrome://ublock0/content/dashboard.html#1p-filters.html chrome://ublock0/content/logger-ui.html

Steps to Reproduce

  1. Switch to GTK dark theme
  2. Run Basilisk and uBO
  3. Go to Dashboard or Logger

Expected behavior:

Input fields and select menus should have same background color as other elements.

Actual behavior:

Input fields and select menus are matched to dark GTK theme.

Your environment

AroKol78 commented 3 years ago

I don't know if it is in the subject but UXP has new settings https://github.com/MoonchildProductions/UXP/commit/e946ca91fb032149131087ce24fbba886c53ee18 0 = feature disabled 1 = default: light theme preferred 2 = dark theme preferred browser.display.prefers_color_scheme 1