Closed DandelionSprout closed 3 years ago
I was told by Raymond several times that using the XUL name against uBO for Firefox Legacy is not correct, so could you please change the title to NOR, DNK, ISL: Dandelion Sprouts nordiske filtre (Legacy)
and the file name to something like NordicFiltersLegacy.txt
?
Sure thing. Give me 10min.
Okay, I seem to have fixed it now.
invalid filter - it is not 100% compatible
I'll look into how to fix them with RegEx. Give me 30min.
Merged in https://github.com/gorhill/uBlock-for-firefox-legacy/commit/8024518ddd356570c137d35e618a09e9b99d5673
I also changed the title to NOR, DNK, ISL: Dandelion Sprouts nordiske filtre – Legacy
just like "uBlock filters - Legacy".
it is strange Invalid network filter in NOR-0: gamereactor.*$$script[onError="adblockEnabled()"]
https://raw.githubusercontent.com/DandelionSprout/adfilt/master/NorwegianExperimentalList%20alternate%20versions/NordicFilters-NotFirefox.txt
!#if adguard
gamereactor.*$$script[onError="adblockEnabled()"]
!#endif
!#if env_firefox
gamereactor.*##^script[onError="adblockEnabled()"]
!#endif
maybe i need a blank line after the first !#endif
The most likely cause was that I was using AntiAdblockEntries.txt
as an !#include
file, despite already being included in the list generation script to begin with, resulting in a few dozen duplicate entries that also were unprocessed by the script.
Removing !#include AntiAdblockEntries.txt
, which I've done now, should fix it.
Hopefully as simple as the title says.
If not, then I've turned on the "Allow edits by maintainers" button for this PR.