search

gorhill / uBlock-for-firefox-legacy

uBlock Origin for Firefox legacy-based browsers.
GNU General Public License v3.0
201 stars 24 forks source link

Ads on CNN videos are no longer blocked. #333

Open zsc4 opened 2 years ago

zsc4 commented 2 years ago

Prerequisites

Description

[Description of the bug or feature] The title says it all. UBO used to block ads on CNN videos 100% of the time. Now it doesn't at all. It's worth noting that CNN seems to change the way they display their videos from time to time. This issue does not occur on the latest version of UBO for Firefox (1.44.2).

A specific URL where the issue occurs

One specific place this happens is https://www.cnn.com/videos/business/2022/09/13/chevron-ceo-mike-wirth-energy-europe-recession-harlow-vpx.cnnbusiness. But it happens on all CNN videos in all editions of the site. [A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

  1. [First Step] Go to https://www.cnn.com/videos/business/2022/09/13/chevron-ceo-mike-wirth-energy-europe-recession-harlow-vpx.cnnbusiness or any similar CNN video.
  2. [Second Step] Wait for the site to load, then press the Play button on the video.
  3. [and so on...] A video ad appears preceding the actual video.

    Expected behavior:

[What you expected to happen] I expected the video to play without an ad.

Actual behavior:

[What actually happened] An ad appeared before the video.

Your environment

zsc4 commented 2 years ago

I tried the filter suggested in the Reddit thread, and it doesn't help.

AroKol78 commented 2 years ago

This is not a repo for the filter list. I think the right place will be to apply to https://github.com/uBlockOrigin/uAssets. That's where they keep the "Legacy" list.

FrostKnight commented 2 years ago

Should I take it, that no one would rather try a different approach of forking a different ublock origin based addon?

I mentioned one in the help wanted issue...

Specifically... this one?

https://github.com/dhowe/AdNauseam/releases/tag/v3.7.802

I would have contacted someone directly, but at this point, there is no other choice.

Btw, the author of that repo said he would link to anyone who wanted to continue the repo, aka, the page of the repo for the legacy version of the above addon, Adnauseam, aka...

I should also add, we don't know when JustOff or Gorhill will be available again to do anything about this...

and as a last thought, there is an option to disable the blocklist in the browsers its for.

Anywho, I hope someone uses some wisdom to do this. Otherwise, there might be a huge long wait.

Just sayin...

:(

zsc4 commented 2 years ago

I reported this problem on the uAssets repository, and with some extremely helpful advice from the folks there, I was able to fix this problem. This fix should work for all users of Pale Moon. You can find my reply containing the fix here.

Gittyperson commented 2 years ago

No CNN video ads here, with Cleanlinks2 installed (no extra configuration). It's similar to Pure URL.

zsc4 commented 2 years ago

Starting today, YouTube ads are back. Nothing seems to get rid of them - not Pure URL, not CleanLinks2. Any help would be greatly appreciated.

Gittyperson commented 2 years ago

Just tried your CNN link again, and there was no ad (CLeanLinks2 installed). I know that website changes do not always apply immediately to all users, but perhaps this is a filterlist issue?

I'm using AdGuard Base instead of EasyList (also, AdGuard Tracking Protection + EasyPrivacy + AdG Annoyances).

(you mentioned a "filter suggested in the Reddit thread", but you didn't mention what it was)

Gittyperson commented 2 years ago

I'd also suggest to update your uBlock Origin version:

How-to - Upgrading to git version of uBlock Origin Legacy

zsc4 commented 2 years ago

Thanks for your help. My uBlock Origin version is current; I see that the last change to the program was more than a year ago.

I was about to try out the AdGuard filters (I had installed CleanLinks2 when you suggested it), but first I thought I would verify that the problem was still there, especially since you said that the link worked for you. This time, I got no ads on any of the CNN videos. As a results, I didn't have to install any of the AdGuard filter lists.

My guess is that CNN temporarily changed something that for some reason caused problems for a small subset of users that happened to include me, and once they discovered the problem (which was probably not connected to ads directly), they changed it back.