gorhill / uBlock

uBlock Origin - An efficient blocker for Chromium and Firefox. Fast and lean.
GNU General Public License v3.0
45.98k stars 3.08k forks source link

using pale moon, I can't bring ublock0 ui via customize #136

Closed isreport closed 9 years ago

isreport commented 9 years ago

Hi, I've installed ublock origin via mozilla addon site on my pale moon browser and cannot seem to find a way to bring in UI icon to toolbar nor status bar. Is this just me or anyone using pale moon? (the version is pale moon 25.3.2 x64) Thanks.

lewisje commented 9 years ago

I think AlexVallat made changes to uBlock to support the non-Australis toolbar, but gorhill has said he won't be importing those Firefox-specific fixes.

EDIT For now it's an experimental build: https://github.com/chrisaljoudi/uBlock/issues/1315

gorhill commented 9 years ago

Yes, I understand some people may not be happy with this, but I do not plan for uBlock Origin to support "legacy" Firefox-based browsers. uBlock will have such support.

gorhill commented 9 years ago

@AlexVallat's work for Firefox legacy support has been imported in uBlock Origin. Currently available in dev build: https://github.com/gorhill/uBlock/releases.

LeafG commented 9 years ago

uBlock 0.9.9.2-dev.1 Pale Moon 25.5.0 (x64) SeaMonkey 2.32.1 Windows 7 x64:

In both browsers I can see (for the 1st time, I think) the uBlock0 logo on the toolbar, and am able to open the popup ui from it (hooray).

In Pale Moon, I have a weird situation: I don't see any logger entries under the specific page of the "page selector", only under "All", and I can't open the popup ui from the logger.

So, I looked at previous versions to see when this started and found that: 0.9.8.6 works as expected: in the page selector of the logger, I can select a page, use the refresh button, and see the entries. I could also open the popup ui from the 2nd column, as expected.

The next version I had was 0.9.9.0 (I didn't get any of the in-between dev versions). Starting from that version, selecting a page and refreshing it, does re-load the page, but with the above described weird situation.

I used yahoo.com, as the only opened tab. My set of dynamic rules (specifically for this test case):

And the default set of 3rd-party filters.

gorhill commented 9 years ago

Looks to me like the javascript code in the logger is throwing. Can you see something at the dev console of the logger tab?

LeafG commented 9 years ago

When I open the "page selector" on the "yahoo" page, and press the re-load, I get a ton of warnings scrolling on the Javascript console, and the following error several times:

Error: getMessageManager is not a function Source file: chrome://ublock0/content/frameModule.js Line: 179

LeafG commented 9 years ago

I think Pale Moon matches FF 24, but I don't know for sure. I just read forums, not use FF itself.

I only used the Javascript console.

I know that the JS debugger stopped working at some point, and now the Tiny Javascript Debugger is suppose to work.

gorhill commented 9 years ago

Fix is in dev.2.

LeafG commented 9 years ago

Yes it works :-) Thank you.

Just FYI: The error still appears: Error: getMessageManager is not a function Source file: chrome://ublock0/content/frameModule.js Line: 179

Even though the logger now works as expected.

gorhill commented 9 years ago

Error: getMessageManager is not a function

I could reproduce if disabling then re-enabling uBlock. This also happens on other versions of FF. I don't know why a certain abnormal condition occurs, but I put code in there to detect that abnormal condition in order to avoid escalating the issue. Next dev build later tonight you can try and report whether this fixed the error messages for you.

LeafG commented 9 years ago

Yes, the error is no longer there with 0.9.9.2-dev.3