search

gorhill / uBlock

uBlock Origin - An efficient blocker for Chromium and Firefox. Fast and lean.
GNU General Public License v3.0
46k stars 3.08k forks source link

Netzwelt.de banner not hidden #1366

Closed ghost closed 8 years ago

ghost commented 8 years ago

Banner ads on netzwelt.de are not hidden.

How to reproduce:

  1. Subscribe to EasyList Germany
  2. Go to http://www.netzwelt.de/news/74353-super-soaker-championship-jugendfreier-online-shooter-kostenlos.html
  3. "Sky" banner ad is not hidden. Might need to wait a few seconds or reload. Maybe delete cache and cookies.

Screenshot Logger

Tried with uBO 1.5.6 in Chrome 48 and with uBO 1.6.0 in Firefox 38.6.0 (fresh profile). Seems to be an issue with uBO since it works with ABP 2.7.1 in Firefox with the same filter lists way more reliably (rare exceptions like here).

zummuz commented 8 years ago

see entry №7 https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md#before-you-submit https://forums.lanik.us/viewtopic.php?f=90&t=27698

gorhill commented 8 years ago

It does not work with Chromium/ABP 1.10.1.

gorhill commented 8 years ago

Just a filter list issue: ||img.netzwelt.de/picture/*/sky-*-*.*.

I use the feature shown here to create that filter + a bit of editing.

ghost commented 8 years ago

@zummuz What are you trying to tell me? I even linked that thread.

@gorhill You are right, it doesn't work with uBO or ABP in Chromium. However it works with ABP in Firefox but not with uBO. Therefore it must be a uBO issue, right? I tried your filter and it blocks the banner. However the page still jumps, splits into pieces and gets dark which doesn't happen in Firefox with ABP. You can even still click the ad when the image is blocked.

gorhill commented 8 years ago

Therefore it must be a uBO issue, right?

uBO works differently than ABP. uBO works the same on any browser. Chromium-ABP works differently than FF-ABP. ABP uses user stylesheet on FF, which override all CSS rules on a page, something not possible on Chromium.

I don't know why the banner does not appear on FF-ABP, as I did not spot any specific CSS rules for that banner -- I would need to investigate more.

In any case, here is a filter which will take care of the banner, and will work better for ABP too, as it removes the placeholder on FF:

www.netzwelt.de###mhc + div[id][class]

It should be proposed for inclusion in EasyList.

ghost commented 8 years ago

Thanks. However the background still gets clickable and dark. I submitted it to EasyList though: https://forums.lanik.us/viewtopic.php?p=86736#p86736

gorhill commented 8 years ago

the background still gets clickable

netzwelt.de###mr
netzwelt.de###ml
netzwelt.de###mhc + div[id][class]