gorhill / uBlock

uBlock Origin - An efficient blocker for Chromium and Firefox. Fast and lean.
GNU General Public License v3.0
45.97k stars 3.08k forks source link

uBO should alternate between SSL/non-SSL #1465

Closed davidhedlund closed 8 years ago

davidhedlund commented 8 years ago

new

new

new

As you can see both the "Update" button and "out of date" indicates a failure (second screenshot) of the current status as it was downloaded (first screenshot). I've repeatedly done this so the "x out of y" filters in the text of the screenshots that appear to not have been updated is correct.

Using uBO 1.6.4.

davidhedlund commented 8 years ago

https://github.com/gorhill/uBlock/issues/132

ghost commented 8 years ago

Works fine on my end. Can you visit this URL? https://mirror.cedia.org.ec/malwaredomains/justdomains

132

That's not the issue you describe though, right? Seems completely unrelated.

davidhedlund commented 8 years ago

@IDKwhattoputhere No, I can only visit the non-SSL connection: http://mirror.cedia.org.ec/malwaredomains/justdomains

gorhill commented 8 years ago

No, I can only visit the non-SSL connection

Not a uBO issue then. CONTRIBUTING: "make the case there is an issue with uBO". This means yes, you will have to investigate on your side, not dump this here for others to investigate for you.

davidhedlund commented 8 years ago

@gorhill There is nothing that says that SSL have to be used in chrome://ublock0/content/asset-viewer.html?url=assets/thirdparties/mirror1.malwaredomains.com/files/justdomains. How do you figure that out?

davidhedlund commented 8 years ago

A solution would be that uBO ask for a non-SSL connection if it cannot establish a SSL connection.

ghost commented 8 years ago

There is nothing that says that SSL have to be used in chrome://ublock0/content/asset-viewer.html?url=assets/thirdparties/mirror1.malwaredomains.com/files/justdomains.

Yes, there is. It says http if the connection is not encrypted.

gorhill commented 8 years ago

That list also ships as part of the package -- so its entry is a key rather than a URL. The URLs to use are all found in [filter-lists.json](https://github.com/gorhill/uBlock/blob/master/assets/ublock/filter-lists.json#L233):

"mirror1.malwaredomains.com/files/justdomains": {
    "title": "Malware domains",
    "group": "malware",
    "homeURL": "https://mirror.cedia.org.ec/malwaredomains/justdomains",
    "supportURL": "http://www.malwaredomains.com/"
},

Why would your browser not be able to load https: resources?

davidhedlund commented 8 years ago

@gorhill >Why would your browser not be able to load https: resources?

Because I use GNU IceCat 38.6.0; there is a bug to connect to certain SSL sites including https://gnupg.org/ (see https://lists.gnu.org/archive/html/bug-gnuzilla/2016-02/msg00004.html).

This is why I suggest that uBO should try connect to non-SSL if it fails with SSL.

gorhill commented 8 years ago

uBO should try connect to non-SSL if it fails with SSL

I am not very fond of the idea of adding code to uBO just for the sake of working around a bug in a browser, which from what I understand can be trivially fixed by users:

For now, users can work around this problem by going into about:config and changing these settings to "true". I'm also going to remove these customizations from the IceCat build in GNU Guix.

This on top of also having a work around in uBO: import the non-https version of the URL as an external filter list.

For these reasons, I decline.

davidhedlund commented 8 years ago

@gorhill I respect your decision, there are more important issues to focus on. Also, this bug should be fixed in IceCat soon. You can flag this issue Declined if you want.

davidhedlund commented 8 years ago

I can reach https://mirror.cedia.org.ec/malwaredomains/justdomains with IceCat 38.7.1 now.