search

gorhill / uBlock

uBlock Origin - An efficient blocker for Chromium and Firefox. Fast and lean.
GNU General Public License v3.0
47.36k stars 3.15k forks source link

Add private mode filters to make uBO part of GNU IceCat #1576

Closed davidhedlund closed 8 years ago

davidhedlund commented 8 years ago

I suggest that SpyBlock (part of GNU IceCat) fork its code from uBlock [Origin] rather than Adblock Plus.

IceCat author (Rubén Rodríguez) responded: "I made the Spyblock hack before uBlock was available (or well known anyway). It could be replaced, provided that we can implement with uBlock the same features SpyBlock provides over Adblock: extra lists that get enabled when entering private mode.

Since Spyblock is providing the desired functionality right now, replacing it for the sake of performance is not a priority compared with improving LibreJS, which is what I'll be working on next. But if somebody wants to contribute that code I'll be happy to add it."

0xBRM commented 8 years ago

Wouldn't that require platform specific changes?

lewisje commented 8 years ago

This would be a good time for someone to make a "SpyBlock Origin" fork or something like that, with the desired platform-specific functionality; I'm thinking that whatever was done to allow an Adblock Plus fork to activate a certain filter-list in private mode would be portable across Firefox extensions.

gorhill commented 8 years ago

I do not intend to create/maintain yet another extension.

davidhedlund commented 8 years ago

@gorhill This is not about create/maintain another extension but to add a private mode detection to uBO. If the author or IceCat would do that, would you adopt it then?

gorhill commented 8 years ago

would you adopt it then?

Most likely not, because I can't make sense of such feature. I fail to see the point of a "non private mode" for uBO, which is what supporting a special "private mode" implies.

davidhedlund commented 8 years ago

@gorhill Thank you. I told the icecat bugzilla mailing list about this so the IceCat maintainer can decide if he think its worth to do it himself.