Element picker: do not prevent the page from receiving mouse-move-related events

gorhill / uBlock

uBlock Origin - An efficient blocker for Chromium and Firefox. Fast and lean.

GNU General Public License v3.0

47.47k stars 3.15k forks source link

Element picker: do not prevent the page from receiving mouse-move-related events #2000

Open gorhill opened 8 years ago

gorhill commented 8 years ago

Describe the issue

Test case was provided by a user on reddit:

Visit http://reddpics.com/r/gif.
Notice that when you hover a thumbnail on the page, a play button appears in its center.
Launch uBO's element picker.
Try to select the play button in any of the thumbnail: you can't.

The play button won't appear unless you hover over the thumbnail, but uBO's page wide overlay prevents the mouse move events from reaching the page, so the thumbnails end up never being hovered.

Atavic commented 8 years ago

Sourcepage has: Event.MOUSEUP and uses http://reddpics.com/assets/jq-plugins/prettyPhoto/js/jquery.prettyPhoto.js that has: .unbind('mouseenter mouseleave')