search

gorhill / uBlock

uBlock Origin - An efficient blocker for Chromium and Firefox. Fast and lean.
GNU General Public License v3.0
47.25k stars 3.14k forks source link

Possibly new filter lists: "Blockzilla", "Czech List" and "Estonian filters by Gurud.ee" #2140

Closed uBlocking closed 7 years ago

uBlocking commented 7 years ago

https://adblockplus.org/subscriptions lists seven subscriptions not included in the 3rd party filters section of uBlock Origin. Of these seven, I can find references to four in this repository along with an explanation of why you will not include it. The remaining three may be "new", so I have listed them below for (temporary) completeness.

Browser/version: Chromium 53.0.2785.143 uBlock Origin version: 1.9.16

Atavic commented 7 years ago

I upvote Blockzilla 'unbloated and slim list' idea.

ghost commented 7 years ago

Blockzilla contains some critical filters like:

||connect.facebook.net^$third-party
||graph.facebook.com^$third-party
||pinterest.com^$third-party
||reddit.com^$third-party

Guaranteed to cause breakage. Many websites use for example Facebook Connect to provide an option for users to login using their Facebook account (not giving a judgement if that's a good or bad idea).

ghost commented 7 years ago

As of Blockzilla Version B20 ||connect.facebook.net^$third-party has been removed. As for the other filters mentioned, no issues have been reported however if issues arise I will whitelist or remove accordingly.

JohnChristianD commented 7 years ago

Adguard's Mobile Ads could be a good alternative. I just hope there are more empirical comparisons between filter lists. Adguard's Japanese filters are also probably a better alternative than the current Japanese filters with false positives.

gorhill commented 7 years ago

Adguard's Mobile Ads could be a good alternative

Currently there is no infrastructure in uBO to auto-select a list at install time according to whether a browser is a mobile version or not. Idea is interesting though.

Adguard Japanese is interesting given how overzealous the current one in uBO is, but I don't see recent commits in there: https://github.com/AdguardTeam/AdguardFilters/tree/master/JapaneseFilter/sections, last meaningful change was 6 months ago.

JohnChristianD commented 7 years ago

There's also the question of if Mobile Ads is supposed to be a standalone filter. If I remember correctly, Adguard Mobile enables Adguard Mobile filters alongside Adguard English.