gorhill / uBlock

uBlock Origin - An efficient blocker for Chromium and Firefox. Fast and lean.
GNU General Public License v3.0
47.38k stars 3.15k forks source link

Open in new tab produces 6+ 'popup' lines in logger #3165

Closed gwarser closed 7 years ago

gwarser commented 7 years ago

Describe the issue

When I open links by middle click or by context menu -> Open Link in New Tab, UBO logger show 6 or more 'popup' events.

One or more specific URLs where the issue occurs

On this page, middle click on Issues on top (or here).

Screenshot in which the issue can be seen

22:57:15       popup https://github.com/issues
22:57:15       popup https://github.com/issues
22:57:14       popup https://github.com/issues
22:57:14       popup https://github.com/issues
22:57:14       popup about:blank
22:57:14       popup https://github.com/issues
22:57:12       popup https://github.com/issues
22:57:12   ||collector.githubapp.com^ -- xhr https://collector.githubapp.com/collect
22:57:12   ||google-analytics.com^ -- xhr https://www.google-analytics.com/r/collect
22:57:12       popup about:blank

Your settings

Your filter lists

Default + POL

gorhill commented 7 years ago

It's a Firefox-specific issue. There so much uBO can do to deal with the way Firefox API fires the tabs.onUpdated event. Even trying to be a bit smarter to avoid the weirdness, I get:

a

Of course it makes no sense that https://github.com/issues became about:blank then back to https://github.com/issues, but that is what Firefox fires to the extension.

gwarser commented 7 years ago

Can be closed - browser issue or something. I put this here only to be documented.

gorhill commented 7 years ago

Well I think I will keep my fix to detect duplicate URLs in onUpdated (the code change seems trivial enough, but then it's difficult to foresee everything), but beyond that the logger will still look weird.

uBlock-user commented 7 years ago

Happens on Chromium 63 too, I get 5 popup entries.

okiehsch commented 7 years ago

With Chrome 62 unbenant