search

gorhill / uBlock

uBlock Origin - An efficient blocker for Chromium and Firefox. Fast and lean.
GNU General Public License v3.0
44.46k stars 2.99k forks source link

False positive / popup blocked #372

Closed smed79 closed 9 years ago

smed79 commented 9 years ago

Hello, on google privacycheckup (2. Improve ad relevance) using Adblock Plus, clicking the link settings/ads open popup to google.com/ads/preferences/checkgoog? but the popup is blocked using uBlock due to redirection to googleads.g.doubleclick.net.

||googleads.g.doubleclick.net^$popup,third-party

Regards, Med

harshanvn commented 9 years ago

It looks like a 3rd party filter issue. For me this filter is listed under - Fanboy+Easylist-Merged Ultimate List

Report it to easy list forum..

gorhill commented 9 years ago

Ok... This does not happen with other blockers. However, AdBlock and Adguard also fails at popup tests 9 and 10, which I believe is the same sort of case here.

There is definitely a filter in EasyList to block popups: ||googleads.g.doubleclick.net^$third-party,popup. So it is unexpected to me as to why is ABP not enforcing that filter. This suggests to me that the popup blocker in ABP would fail some tests.

So I will create an exception filter in uBlock, because I do believe uBlock is doing the right thing by enforcing that popup blocker filter in EasyList.

However, after I created the exception filter, the problem persisted. There is another bug lurking in static filtering engine regarding exception filters, and trying to create the exception filter uncovered this bug, which is a regression bug from 61dc1b780807686b0e8d952d85ba4516ff34e926. This is a rather serious bug, and that it didn't manifest itself more prominently is because it manifest itself only for specific requests. This needs fixing ASAP.

gorhill commented 9 years ago

Assessing the impact of the regression bug, I found 23 filters in EasyList which were affected by it:

@@||doubleclick.net^*/targeted.optimum/*;sz=968x286;$image,popup,script
@@||ads.stumbleupon.com^$popup
@@/redirect.aspx?pid=*&bid=$popup,domain=betbeaver.com
@@||adfarm.mediaplex.com/ad/ck/$popup,domain=betwonga.com|pcmag.com
@@||ads.betfair.com/redirect.aspx?pid=$popup,domain=betwonga.com
@@||ads.flipkart.com/delivery/ck.php?$popup,domain=flipkart.com
@@||ads.pinterest.com^$popup,~third-party
@@||ads.reempresa.org^$popup,domain=reempresa.org
@@||ads.sudpresse.be^$popup,domain=sudinfo.be
@@||ads.twitter.com^$popup,~third-party
@@||ads.williamhillcasino.com/redirect.aspx?*=internal&$popup,domain=williamhillcasino.com
@@||adserving.unibet.com/redirect.aspx?pid=$popup,domain=betwonga.com
@@||adv.blogupp.com^$popup
@@||bet365.com/home/?affiliate=$popup,domain=betbeaver.com|betwonga.com|betyper.com
@@||doubleclick.net/click%$popup,domain=people.com|time.com
@@||doubleclick.net/clk;$popup,domain=hotukdeals.com|jobamatic.com|play.google.com|santander.co.uk|techrepublic.com
@@||doubleclick.net/ddm/clk/$popup,domain=couponcodeswap.com
@@||g.doubleclick.net/aclk?$popup,domain=bodas.com.mx|bodas.net|casamentos.com.br|casamentos.pt|casamiento.com.uy|casamientos.com.ar|mariages.net|matrimonio.com|matrimonio.com.co|matrimonio.com.pe|matrimonios.cl|weddingspot.co.uk|zillow.com
@@||gsmarena.com/adclick.php?bannerid=$popup
@@||serving-sys.com/BurstingPipe/adServer.bs?$popup,domain=jobamatic.com
@@||viroll.com^$popup,domain=imagebam.com|imgbox.com
@@||imagebam.com/image/$popup
@@||supportchat.contentabc.com^$popup,domain=brazzerssupport.com

The regression bug affected only exception filters of type popup.

Piter432 commented 9 years ago

Similar problem is with gamersyde.com, while trying to watch the screenshoots from video games. The window with a screenshoot is blocked by uBlock Origin, even I allowed to open pop-ups in gamersyde (the first site-based switch doesn't have "X" on it's icon).

gorhill commented 9 years ago

trying to watch the screenshoots from video games

Without a specific URL, I can't do anything.

gorhill commented 9 years ago

I tried here http://www.gamersyde.com/game_images_2849_en.html, and it works all fine with default settings. Check your logger, it will tell your which filter is causing you problem.

Piter432 commented 9 years ago

Unfortunately, I tried to investigate that in the logger and tried dynamic and static URL filtering and tried many combinations with this two URL filtering - effect is always the same as I described earlier.

gorhill commented 9 years ago

Again, you do not provide a specific case. It's impossible for whoever to provide an answer to your issue. I did provide a specific case, and it worked fine.

Piter432 commented 9 years ago

This happens on all gamersyde pages, that contain at least one screenshot from any video game and after clicking on the picture are opening in gamersyde pop-up window. The example URL to my problem is that you've provided and similar to them like this: http://www.gamersyde.com/news_resident_evil_0_hd_trailer_screens-16608_en.html

gorhill commented 9 years ago

http://www.gamersyde.com/news_resident_evil_0_hd_trailer_screens-16608_en.html

It worked fine here. The logger will tell you what request got blocked and why.

Piter432 commented 9 years ago

Looks like the static filter pop$popup, which is in JPN: ABP Japanese filters (日本用フィルタ) is causing this problem, but I don't want to turn off this filters list.

Blutgang commented 9 years ago

@Piter432 That page is weird... Some of the pictures are not blocked as a popup and some are... Hmm...the logger shows the filter as pop$popup but the JPN list shows ^pop_$popup instead. I'm not very good at writing filters. You can try @@||gamersyde.com/pop_$popup or @@^pop_$popup,domain=gamersyde.com

Edit: Wait. Didn't uBlock 0.9.9.0 have the ability to create static filters? You can write an exception filter to the problematic filter.

smed79 commented 9 years ago

@Piter432 repport this issue to JPN list autor @k2jp.

Piter432 commented 9 years ago

@Blutgang All your propositions didn't help :(

@SMed79 Issue reported. I hope that he can find a fix for that :)

gorhill commented 9 years ago

All your propositions didn't help :(

If gamersyde.com has no nasty popups, just use @@||gamersyde.com^$popup,first-party.

Piter432 commented 9 years ago

@gorhill Didn't help :(

gorhill commented 9 years ago

It works in 0.9.9.2.

Piter432 commented 9 years ago

Eh, I forgot I'm using Chrome now and newest version in their Web Store is 0.9.9.1. Sorry for that :(

I will wait for update to uBlock Origin for Chrome and then I will try. If everything will be ok, I will close this issue (lol, just discovered that issue is not mine and it's closed already) inform you about that.

Piter432 commented 9 years ago

Okay, so the issue is resolved after updating uBlock Origin to version 0.9.9.2. Thanks for help :)

ryanbr commented 8 years ago

I was trying to reproduce this issue, and the page in question still launches in Adblock Plus fine

TeddStriker commented 8 years ago

@ryanbr

The poster above you said that the issue was fixed.

Okay, so the issue is resolved after updating uBlock Origin to version 0.9.9.2. Thanks for help :)

I don't really see how it launching in ABP is relevant.

ryanbr commented 8 years ago

Very relevant. If this was to be included into Easylist I need to reproduce this in ABP. If its an issue with uBlock then nothing will be done.

gorhill commented 8 years ago

If its an issue with uBlock then nothing will be done.

Yes, this was an issue in uBlock (regression), affecting filters with both the popup and third-party options.