search

gorhill / uBlock

uBlock Origin - An efficient blocker for Chromium and Firefox. Fast and lean.
GNU General Public License v3.0
44.49k stars 2.99k forks source link

Attempted to increase the "lists too many" treshold #3909

Closed DandelionSprout closed 7 months ago

DandelionSprout commented 7 months ago

In large part inspired by https://github.com/DandelionSprout/adfilt/issues/960, it has turned out that a limit of 12 added lists in the User Support settings info is unfortunately too low for at least me. The result of the limit was that I had no idea if that reporter had Frellwit's Filters turned on or not, and I take an unqualified guess that Frellwit was unsure too.

So I attempted to increase it from 12 to 25. 20 didn't feel like enough, while 30 would seem like a pretty big change for a PR.

I don't think this change will affect anyone else's filterlist maintenances, so I hope that this is indeed suited as a PR. On request, I could set up a uBlock-issues thread connected to this PR for broader communications and such.

gwarser commented 7 months ago

This limit is here for technical reasons. Too long text will cause error on GitHub side, and you will be not able to post new issue. It can be make smarter - when there are a low number of domains blocked and extended filters reported then allow more lists to be shown, but it's more work.

gwarser commented 7 months ago

On the other hand, when manually copying the info, there should be no problem. It only happens when creating issue directly from uBO interface.

And an idea - uBO can send only a token in a new issue URL and then fill the form by script injected on new issue URLs. Lot of work.

gorhill commented 7 months ago

Declined because of https://github.com/uBlockOrigin/uBlock-issues/issues/1852.