search

gorhill / uBlock

uBlock Origin - An efficient blocker for Chromium and Firefox. Fast and lean.
GNU General Public License v3.0
47.36k stars 3.15k forks source link

[0.9.4.4-dev.1] New gnuzilla filterlist not available #77

Closed ghost closed 9 years ago

ghost commented 9 years ago

I can't see the new filterlist.

After unpacking ublock0.chromium.zip there is no appropriate subfolder in ...assets/thirdparties. Even after manually adding the gnuzilla.gnu.org subfolder from the zip file and restarting Chrome that filterlist doesn't show up.

gorhill commented 9 years ago

The filter list is definitely in there, what is missing is an updated filter-lists.json. There are many changes in filter-lists.json, to fix a handful of old issues about obsolete or moved filter lists, and I want to wait for the week-end for these changes -- maybe tonight, as this will test code path which has never been really tested yet -- the seamless migration from one filter list to a new version at a different location.

ghost commented 9 years ago

I see. FWIW, gnuzilla.gnu.org seems to be offline right now.

anewuser commented 9 years ago

@gorhill maybe you already know this, but that list is actually an automatically parsed and edited mix of other filters already included in uBlock preferences, including EasyList. It may not be a good idea to keep it in uBlock, at least not with the current description of it being just a list to "Block all well known privacy trackers‎".

For example, it currently includes this rule, which breaks a lot of valid websites:

||amazonaws.com^$script,third-party

See this example: https://www.instapaper.com/text?u=gnu.org

I've already reported this to the author of the script, but this list may continue to be problematic since it uses automatic rules.

gorhill commented 9 years ago

Removing would be problematic, many people may use it already. I can add a note though, like "high breakage", or whatever concise expression is better to indicate that it has a higher likelihood to cause web pages to break.

anewuser commented 9 years ago

@gorhill Thank you for adding the warning. It is also blocking ||imgur.com^$image,third-party, which is one of the most popular image hosting sites today. If you decided to remove it from the filters officially endorsed by you, couldn't you move it to the "custom filters" of users who are using it already, along with a comment about it?

gorhill commented 9 years ago

It is also blocking ||imgur.com^$image,third-party

Yeah, that's problematic. I had assumed this was a well groomed filter lists given the name and origin.

Given the content of this list, for someone who would want to use such list, best option is instead to turn on default-deny in dynamic filtering, at least this way one can easily un-break whatever sites end up broken, which is not the case when using a static filter list.

However I cannot make a clean transition like you propose, because the available filter lists are updated dynamically, this means there won't be special code path in existing uBlock installations to take care of moving it to custom filters.

I will have to remove it and just document why, the sooner the better.