gorhill / uBlock

uBlock Origin - An efficient blocker for Chromium and Firefox. Fast and lean.
GNU General Public License v3.0
47.49k stars 3.16k forks source link

Turkish Filter #952

Closed bkrucarci closed 8 years ago

bkrucarci commented 8 years ago

Hello, Can you please address this filter for Turkish users? The filter source is open to everyone to use. Please add this as third party filter just like other countries filters. It has special rules for Turkish sites. https://adguard.com/ru/filter-rules.html?id=13

If you accept to add this filter, then can you please enable this when a Turkish user installed uBlock Origin. uBlock can detect browser language to enable this rule? Please tell me what you think.

bkrucarci commented 8 years ago

BUMP!

gorhill commented 8 years ago

It contains Adguard-specific filter syntax, consider the result undetermined when loading this filter list into uBO.

bkrucarci commented 8 years ago

Yes, I realized that rules are not working on uBO. But other many rules works fine. Is not it worth to add into uBO ?

bkrucarci commented 8 years ago

Thank you for your interest! I will close the topic.

bkrucarci commented 8 years ago

Hey gorhill, Again me. What about this filter? I created this one for your needs! https://github.com/bkrcrc/turkish-adblocklist

Please reply, I do not want to wait an answer for days. Thanks

gorhill commented 8 years ago

After looking at the details of Adguard-specific syntax, I decided that I will make uBO be able to import Adguard filter lists, but all unsupported Adguard-specific syntax will be discarded by uBO.

There is one instance of Adguard-specific filter which could be translated into a uBO-specific filter[1], but this will be implemented maybe at some point in the future. For now I prefer to limit the amount of changes.


[1] Adguard's example.com$$script[type="text/javascript"][tag-content="bestpizzaeverad.com"] = uBO's example.com##script:contains(bestpizzaeverad.com).

bkrucarci commented 8 years ago

Thank you, what about my list?

gorhill commented 8 years ago

There is still an Adguard-specific filter in your list -- that's why I decided to foolproof uBO for when importing filter lists with Adguard-specific filters.

bkrucarci commented 8 years ago

Can you please tell me which strings are they? I can remove them to make you add this filter :smile:

gorhill commented 8 years ago

https://github.com/bkrcrc/turkish-adblocklist/blob/d041f71f61e97989add3123c40d21ffa3fab7577/turkish-adblocklist.txt#L14

Any filter with an occurrence of #$#, #@$#, #%#, #@%#, and $$ will be rejected by uBO.

bkrucarci commented 8 years ago

Only this rule broke the rule. Now, I updated the list and I searched for other rejected items. Can you please check again? Thank you by the way. Edit: I removed redundant filters, too.

bkrucarci commented 8 years ago

I saw that in changelog, we can use Adguard Turkish list. So there is no need for my filter. Just another question again? Can uBo enable this filter after installation of uBlock on Turkish browsers? Thanks.

gorhill commented 8 years ago

Can uBo enable this filter after installation of uBlock on Turkish browsers?

This would be a duplicate of #747.

Also, I can't add the Turkish filter list in uBO's set of filter lists until I am confident everybody is using a version which can deal with Adguard filter lists.