search

gorhill / uMatrix

uMatrix: Point and click matrix to filter net requests according to source, destination and type
GNU General Public License v3.0
4.56k stars 472 forks source link

Fix as suggested in https://github.com/uBlockOrigin/uMatrix-issues/is… #1008

Closed uBlock-user closed 5 years ago

uBlock-user commented 5 years ago

@gorhill

gwarser commented 5 years ago

No checks for pre 72? Re: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-extensions/vYIaeezZwfQ

uBlock-user commented 5 years ago

I didn't add any checks, if that's what you mean, just the required header for uMatrix to get COOKIE blocking and REFERRER blocking functionality back.

gorhill commented 5 years ago

It's fixed on my side since yesterday. You can't just add extraHeaders like this, you have to check for version otherwise this breaks pre-73 versions and whether this is Chromium.

uBlock-user commented 5 years ago

It's fixed on my side since yesterday

How ? It affects all the dev/beta builds of Chromium. I can still reproduce, so what changed on your side ?

whether this is Chromium.

I looked for Chromum folder and it only had a python file and nothing else.

gorhill commented 5 years ago

"Fixed on my side" means I already have the fix locally. I didn't immediately commit/tag a new build because it's on top of another fix, and I wanted to test more. Just adding extraHeaders breaks Chromium pre-72 (first thing I checked) and possibly Firefox. However I revised the fix to use the approach from the Chromium dev pointed above by @gwarser, I was testing using vAPI.webextFlavor -- which works fine but I prefer the officially suggested approach.

Also, it's not needed for onHeadersReceived.

uBlock-user commented 5 years ago

Does this affect uBlock too ? Lets say I have a scriptlet thats designed for not sending cookies, would it work without extraHeaders in uBO ?

gorhill commented 5 years ago

Lets say I have a scriptlet thats designed for not sending cookies

Makes no difference, there is no code in uBO to deal with Cookie header.

uBlock-user commented 5 years ago

No my question is will my cookie blocker scriptlet work or to simply put are scriptlets affected by this ?