search

gorhill / uMatrix

uMatrix: Point and click matrix to filter net requests according to source, destination and type
GNU General Public License v3.0
4.55k stars 470 forks source link

overflow of dropdown menu if there are too many domains to fit in the browser #693

Open elypter opened 7 years ago

elypter commented 7 years ago

on this page for example there are too many rows for them to be visible and you cannot scroll down http://www.sciencechannel.com/tv-shows/nasas-unexplained-files/nasas-unexplained-files-videos/nasa-astronauts-discuss-extraterrestrial-life/

the problem occured with umatrix 0.9.3.6 on vivaldi 1.6.689.46 (Stable channel) (32-Bit) on linux mint

Saucermote commented 7 years ago

Take a page such as http://digiday.com/ and set your browser to a smaller windowed mode if your monitor is too big to reproduce. The website connects to so many sources that the list gets huge, and there is no ability to scroll the extension popup.

This goes hand in hand with my request here https://github.com/gorhill/uMatrix/issues/683

I never think to come here and post when I hit a page with enormous numbers of requests to external sites, but invariably they are a million links to ad networks and cdn's, and they just start dropping off the bottom of the screen and you can't get to them. The above site is just an example with a large number of requests I found with a google search. It would just be nice if a scroll bar was a toggle in the options please to not inconvenience others without this problem.

Like the above poster, I'm running Vivaldi, a Chromium browser, but I'm on Windows 7.

mitigd commented 7 years ago

I've had this issue also. When I install umatrix in chrome and load a website with a lot of requests it works as intended with a scrollbar, however in Vivaldi this doesn't work for me. The log shows the requests but there is no scrollbar.

This is in Windows & Linux.

Saucermote commented 7 years ago

I'll file a report with the Vivaldi team.

elypter commented 7 years ago

it seems to be fixed now

Saucermote commented 7 years ago

I'm not sure what changed, but the problem has somehow gotten worse. It now scrolls (no scroll bar, but mouse scroll works), but it routinely cuts off items at the bottom and I can't scroll down to them (somtimes they are half cut off and I can see the top of them), especially if blocked domains are collapsed. It typically gets worse if I need to enable a script or other item and reload the page, and it causes the page to load additional domains or subdomains.

Edit: Here I was browsing the Square-Enix store and having a dickens of a time getting down to pepitastore item I need to enable. Even now when I go back to that tab the Umatrix extension window is showing some minature version of itself.

https://store.eu.square-enix.com/eu

This is scrolled down all the way, see how the twitter item is cut in half and it doesn't even get to the banned domains. Opening other tabs and resizing windows seems to change the point at which it errors out.

umatrix

gorhill commented 7 years ago

The CSS style of the body element in the popup panel is overflow-y: auto, so the browser should enable the scroll bar if the content's height is larger than the body's height. The iframe in which the popup panel page is embedded is completely controlled by the browser. From what I see, it's as if the iframe's height is not adjusted by the browser to fit the popup panel's height. This is a browser issue, there is no way for uMatrix to know the size of the iframe in which it is embedded, it's under the control of the browser.

Saucermote commented 7 years ago

The fix that they did wasn't in response to the bug report I submitted before, or at least no only due to it, as the numbers didn't match up. But my monitor is a standard 1080 pixel height, so there is no reason the browser should be triggering this at that height unless they took a shortcut like ublock-o was doing with Firefox to trigger the scrollbar. I'm not even sure what to send over as a bug report other than to just try to point them to this issue thread again.

hipunk commented 6 years ago

I filed a bugreport as well.

gorhill, can't you implement a temporary workaround for us? Everything works, all of the features, but we cannot click the items.

My Firefox is dead, I need a browser ASAP.

Pleeaaaase? Pretty please?

Greetz,

hipunk

hipunk commented 6 years ago

Doh!

It seems that the bug was/is merely the user interface scaling in vivaldis preferences! Click reset in the settings of vivaldi, like here: https://imgoat.com/uploads/93f65e080a/58108.png And it works again.

To me, it seems like this bug can almost be closed here.

Greetz,

hipunk

uBlock-user commented 6 years ago

@gorhill Happens on behind-the-scene scope on current uMatrix dev build with Chromium 65

STR

Remove matrix-off: behind-the-scene true rule and commit the removal.

Browse to chrome-extension://eckgcipdkhcfghnmincccnhpdmnbefki/dashboard.html#hosts-files

Click Purge all caches followed by Update Now

Click on the uMatrix extension icon to open the PopUp UI and scroll to the end to notice the entire row with the domain pgl.yoyo.org has been cut.