search

gorhill / uMatrix

uMatrix: Point and click matrix to filter net requests according to source, destination and type
GNU General Public License v3.0
4.56k stars 472 forks source link

[v1.0.0 webext] Icon not displayed #763

Closed TriMoon closed 6 years ago

TriMoon commented 7 years ago

Conforming to https://github.com/gorhill/uMatrix/blob/master/CONTRIBUTING.md,

1) Due to unsigned extension: 1) Follow the instructions at MSC to flip the setting xpinstall.signatures.required to false 1) Install uMatrix.webext.xpi v1.0.0 1) Open Firefox's customize page via the ≡ menu, The uMatrix icon will be blank, eg. not displayed.

Due to this issue it will be very hard for users to organize where they want the icon to be displayed...

Using: FireFox Developer-Edition on Debian 9 Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0 ID:20170414074709 CSet: 189ed7b2306fcf0a7683df6959b78fdb94bb34e7

gorhill commented 7 years ago

I could reproduce when I drag-n-dropped the xpi file into Nightly. However I can't reproduce once I restart the browser.

Never mind, it happens kind of randomly apparently.

gorhill commented 7 years ago

I can't reproduce when starting Nightly.

I can reproduce all the time when disabling then enabling uMatrix/webext. There are no errors reported at the browser console. uBO/webext does not suffer the issue.

gorhill commented 7 years ago

Spotted at bugzilla: blank browserAction with extensions.webextensions.remote=true.

Darkspirit commented 7 years ago

I created that bugzilla entry: The dropdown bubble is empty when extensions.webextensions.remote=true.

But this bug here is different. This happens with extensions.webextensions.remote=false (default). That STR from the bug reporter are correct. If I open a new tab with Ctrl+T, uMatrix does not have an icon. If I then type in about:newtab and press enter, uMatrix gets an icon and recognizes newtab.about-scheme. screenshot_20170501_123545

Beside those two bugs, everything is working as expected (I think).