gorhill / uMatrix

uMatrix: Point and click matrix to filter net requests according to source, destination and type
GNU General Public License v3.0
4.55k stars 470 forks source link

Matrix UI fails to visually report rules from below base domain level #899

Closed gorhill closed 6 years ago

gorhill commented 6 years ago

Test case:

Add following rule:

* net * block

Visit https://arstechnica.com/.

The page will be broken. This is the expected result given the above rule and that the page is pulling CSS/image resources from arstechnica.net.

The matrix UI however does not visually reflect the block rule:

a

The base domain arstechnica.net (and all of its subdomains) should be reported as being blacklisted -- dark red.

gorhill commented 6 years ago

Actually, issue is invalid -- this is the by-design behavior, reporting descendant hostnames as dark red would mislead the user into thinking there are explicit block rules for all descendants, while this is not the case. Below base domain rules can only be set manually, and thus it is expected the user will understand why a specific domain is reported as blocked despite the visual discrepancy. I had gone through all that thinking a long while ago, just forgot about all this.