search

gorhill / uMatrix

uMatrix: Point and click matrix to filter net requests according to source, destination and type
GNU General Public License v3.0
4.55k stars 470 forks source link

Fix and update legacy firefox vapi-client in the style of fa2658c #900

Closed calibrations closed 6 years ago

calibrations commented 6 years ago

Although support for legacy firefox versions has been dropped, a number of people (myself included) have been trying to build from source. This worked fine until the messaging changes in fa2658c; here I have attempted to fix it myself using the code from the chromium version and uBlock Origin as a guide.

More generally, are you still happy to accept changes to legacy firefox code? Apologies if a pull request completely out of the blue is unwelcome, I am very new to this.

Edit: While I'm here I must add a massive thank you for all your work on this and uBO

gorhill commented 6 years ago

Merging changes as is, with no code review or testing, just for your convenience.

calibrations commented 6 years ago

Oh OK, thank you very much! If there's anyone else looking at this I would appreciate a second pair of eyes over this, I totally appreciate that you can't provide support for it.