search

gorhill / uMatrix

uMatrix: Point and click matrix to filter net requests according to source, destination and type
GNU General Public License v3.0
4.55k stars 470 forks source link

Placeholder in logger "Network error" message is not replaced #945

Closed xofe closed 6 years ago

xofe commented 6 years ago

When an asset can't be downloaded, the message "Network error: Unable to connect to {{url}}" is shown in the logger with the {{url}} placeholder not replaced by the URL that failed to load. This is due to the line 104 of src/js/assets.js trying to replace {{msg}} instead of {{url}}.

I reported a similar issue a while ago for uBO (https://github.com/gorhill/uBlock/issues/2921), which you understandably closed as an external translation issue, but for uMatrix this affects every language (including English) so seems like something that should be fixed in uMatrix itself.

gorhill commented 6 years ago

Fixed in fe995d2bc8e5.

uBlock-user commented 4 years ago

Bug is back in 1.4.1b3, block any HOSTS list url, force update that HOSTS list and check the logger for that msg.

@gorhill