Open ryskin opened 2 months ago
i had a similar error but it was on web platform, was this on web too or ios or android
I'm on iOS and Android and I ran into this too when running bridgeless. I actually tried just commenting out the code where that error is thrown https://github.com/gorhom/react-native-bottom-sheet/blob/4b2a73991d4356ab13904262206abd3e6c8e2869/src/utilities/getRefNativeTag.ts#L30-L40 and it seemed to work. Not sure if that's actually viable though.
+1
I'm getting this same error when I enable the new architecture using Expo SDK v50. Turning off the new arch makes it work again.
i had a similar error but it was on web platform, was this on web too or ios or android
@karam1ashqar were you able to resolve for web? running into this too
i had a similar error but it was on web platform, was this on web too or ios or android
@karam1ashqar were you able to resolve for web? running into this too
no, you need to not use BottomSheetFlatList and BottomSheetScrollView on web
Getting this issue on Expo 51
can someone please share a minimal reproducible example that we can clone and run?
Here ya go: https://github.com/zibs/bottom-sheetflat-list-mcve -- I think you'll need to clone and npx expo run:ios
It has new arch/bridgeless enabled and throws the error in the logs/renders nothing in this case
@zibs My investigation lead me down the same path as you (to patch-package out the throw
). It appears that this bug was introduced in #1100 (released in v4.4.5)
Discord maintains their own fork of this repo and uses the new arch and has reverted #1100 in their fork.
Looking at other related issues i'm finding that for new architecture and web support, react-native-reanimated
kept the findNodeHandle
but not on web since it's not supported. Commenting out this throw
also appears to make expo-web work as well. I'll keep using my patched version and report if i see any issues, but that Error was there for a reason, probably... maybe.
Screenshot from @zibs's repo:
@AndreiCalazans would you be ok to have a look at this issue? It seems that the getRefNativeTag() is not working with Expo 51 / React Native 74
Hey @obasille I've proposed removing the getRefNativeTag in favor of findNodeHandle here https://github.com/gorhom/react-native-bottom-sheet/pull/1823 but it has not been merged, I suggest patching until that lands if you desire to unblock yourself.
Any progress on this issue? This is still relevant for iOS and android for me while using BottomSheetFlatList
on new architecture. Few solutions suggest using FlatList
from react-native-gesture-handler
but I don't think its a proper fix to the problem.
Bug
I encountered an error when trying to use
@gorhom/bottom-sheet
with bridgeless mode in Expo 51.Environment info
Steps To Reproduce
BottomSheetScrollView
in a component.Describe what you expected to happen:
BottomSheetScrollView
should render without errors.Reproducible sample code