gorhom / react-native-bottom-sheet

A performant interactive bottom sheet with fully configurable options πŸš€
https://ui.gorhom.dev/components/bottom-sheet
MIT License
6.64k stars 736 forks source link

[v5] | [v3] createBottomSheetScrollableComponent's ScrollableComponent needs to return a reference that contains a nativeTag to a Native HostComponent. #1871

Open wogno opened 2 months ago

wogno commented 2 months ago

Bug

Capture d’écran 2024-06-28 aΜ€ 21 29 07

Environment info

Library Version
@gorhom/bottom-sheet 5.0.0-alpha.10
react-native 0.74.2
react-native-reanimated ^3.12.1
react-native-gesture-handler ^2.17.0

Steps To Reproduce

  1. I installed and dependencies(rect native navigation,gesture handler, ....
  2. pod install
  3. Follow the code one home page

Describe what you expected to happen:

  1. Sheet open with his content

Reproducible sample code

Same with home page

<BottomSheet ref={bottomSheetRef} onChange={handleSheetChanges}

Awesome πŸŽ‰
arbaaz-suggaa commented 1 month ago

any update on this?

wogno commented 1 month ago

Not official comment but I found at patch that can resolve it, but still have snatpoint not working well.

path name: @gorhom+bottom-sheet+5.0.0-alpha.10.patch

diff --git a/node_modules/@gorhom/bottom-sheet/src/utilities/getRefNativeTag.ts b/node_modules/@gorhom/bottom-sheet/src/utilities/getRefNativeTag.ts index d4f3cc4..794a175 100644 --- a/node_modules/@gorhom/bottom-sheet/src/utilities/getRefNativeTag.ts +++ b/node_modules/@gorhom/bottom-sheet/src/utilities/getRefNativeTag.ts @@ -27,17 +27,17 @@ export function getRefNativeTag(ref: unknown) { nativeTag = ref.current._nativeTag; }

wogno commented 1 month ago

@gorhom+bottom-sheet+5.0.0-alpha.10.patch

wogno commented 1 month ago

You can use this one waiting the official update.

arbaaz-suggaa commented 1 month ago

okay thanks

Feridinha commented 1 month ago

You can use this one waiting the official update.

Thank you

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

piotr-sobczyk commented 2 weeks ago

I think this has been solved by 4.6.4 version (link), and more specifically by this part:

replace getRefNativeTag with findNodeHandle (https://github.com/gorhom/react-native-bottom-sheet/issues/1823)(by @AndreiCalazans) (b906f5e)

In that version the nativeTag error has been fixed but instead there is some console.warn being printed now πŸ˜… (I reported it here)

gorhom commented 5 days ago

could you test on alpha11 ?