gorhom / react-native-bottom-sheet

A performant interactive bottom sheet with fully configurable options 🚀
https://gorhom.dev/react-native-bottom-sheet/
MIT License
7.08k stars 777 forks source link

[Bug]: Laggy and doesn't fully open with new architecture #2046

Open aldebout opened 4 days ago

aldebout commented 4 days ago

Version

v5

Reanimated Version

v3

Gesture Handler Version

v2

Platforms

iOS

What happened?

I just switched from expo 50 / RN 0.74 / old architecture to expo 52 / RN 0.76 / new architecture. The library upgrade went without problems but when I switched to the new architecture, most bottom sheets are laggy or don't fully open the first time I mount them on iOS simulator (I haven't tested on a real device yet).

First video is with expo 52 and old architecture, second and third videos are with expo 52 and new architecture. The event sheets are dynamically sized, and the location ones have fixed snap points.

I'm wondering if other people are experiencing similar issues? I've looked at a bunch of threads and some comments hint at similar problems with Fabric, but I haven't found one that fit exactly this case.

https://github.com/user-attachments/assets/edeefd01-73aa-4fb3-9baa-874a5b6affce

https://github.com/user-attachments/assets/3a345692-a752-4cd5-819e-0427f8281a30

https://github.com/user-attachments/assets/91e29956-52ec-40f8-8703-29dcdf38ccbf

Reproduction steps

At this point I don't know how to properly repro, I just added newArchEnabled: true to app.config.ts, rebuilt and the issue appeared. I've tried switching again and the problem disappears on the old arch + rebuild.

I've also tried removing Sentry in case it was the problem but it does not seem to make a difference. Other potentially conflicting libraries: nativewind, tanstack query with useQuery hooks in the bottom sheets (wrapped through trpc).

I added a straight link to the snack template with this lib and RNR bumped to the latest version and expo switched to 52. It looks janky to me but honestly with snack it's impossible to tell.

Reproduction sample

https://snack.expo.dev/@alexdb/bottom-sheet---issue-reproduction-template

Relevant log output

No response

blaemmle commented 3 days ago

Hey I have the same issue.

juan-vilas commented 2 days ago

same issue here, it's laggy if using the new architecture