gorhom / react-native-paper-onboarding

Paper Onboarding is a material design UI slider for `React Native`.
MIT License
854 stars 50 forks source link

Support for react-native-reanimated v2 #26

Closed RatebSeirawan closed 3 years ago

RatebSeirawan commented 4 years ago

Feature Request

Support for react-native-reanimated v2

Why it is needed

from react-native-reanimated v2 migration docs it says that it's backward compatible with some changes like changing

import {interpolate} from 'react-native-reanimated';
// to
import {interpolateNode} from 'react-native-reanimated';

I tried renaming all the imports but it won't work, I'm currently trying to re-implement the component with the new API but it needs some learning curve to do so.

Possible implementation

Code sample

gorhom commented 4 years ago

hi @RatebSeirawan ,

i did not try to migrate to reanimated v2, but that i would pick this when it's stable. However, if you are interested in contributing you could submit a pr and we could take prepare an alpha release for this lib with reanimated v2

drewandre commented 4 years ago

@RatebSeirawan did you get "malformed js calls" error ( cannot be used as animated value) after changing interpolate -> interpolateNode? That's what I was seeing.

RatebSeirawan commented 4 years ago

@drewandre yes, js error like yours

gorhom commented 4 years ago

i have looked into the issue, seems it is not backward compatibility 100% , migrating to Reanimated V2 will need a refactor :\

gorhom commented 3 years ago

this should be resolved with v1.1.0 👍