gorhom / react-native-sticky-item

An interactive sticky item inspired by Facebook Stories.

MIT License

891 stars 48 forks source link

refactor: copy redash used functionality #24

Closed gorhom closed 3 years ago

gorhom commented 3 years ago

22

Motivation

in this pr, i have embedded the used functionalities from Redash, to allow user to install latest version without having conflict.

Testing

yarn add ssh://git@github.com:gorhom/react-native-sticky-item#feature/clone-redash-functionality

gorhom commented 3 years ago

@Hirbod could you test this pr and let me know if it fixes your issue, thanks

hirbod commented 3 years ago

@gorhom yupp, crash is gone. Many thanks for that. I tried a similar path but failed to parse the SVG. The only thing thats left (but not important for #22) is

%s: Calling getNode() on the ref of an Animated component is no longer necessary. You can now directly use the ref instead. This method will be removed in a future release., FlatList, getNode()

StickyItemFlatlist.tsx, 157

    useImperativeHandle(ref, () => flatListRef.current!.getNode());

But this will force React Native 0.63

hirbod commented 3 years ago

@gorhom do you need any further assistance for a new release? This PR fixes the crash issue. Not sure what you think about the getNode warning.

gorhom commented 3 years ago

@Hirbod thanks for testing this PR, i look into getNode warning this weekend, sorry for the delay