gorhom / react-native-sticky-item

An interactive sticky item inspired by Facebook Stories.
MIT License
891 stars 48 forks source link

Issue with hitslop #4

Closed hirbod closed 4 years ago

hirbod commented 4 years ago

Hello @gorhom . I wanted to thank you again, after a long time of trying I was able to replace Recylerview with your library and achieved a very satisfying performance.

The only problem I could not solve yet is the hitslop of the sticky element. Since the element overlays my thumbs, which are also clickable, I often have two actions (once opening my story and once the action on the button).

How can I optimize this? I would like to be able to define a larger area so that no touch is registered on the thumbnail.

I have made you a video to illustrate this. https://streamable.com/pmlrit

Unfortunately you can't see my finger on the video, but I always try to open the action of the sticky element only, but I always open the story too. Only if I touch in a very special area I get it right but the UX is not so good at this.

gorhom commented 4 years ago

this been fixed with Release v1.2.0

hirbod commented 4 years ago

@gorhom unfortunately its not fixed on android. And android really doesn't care where in that area I tab, it always fires both the item and sticky press. iOS is working perfectly fine

gorhom commented 4 years ago

ughhh , okay i'll look into later today 👍

gorhom commented 4 years ago

hi @Hirbod could you try install from master, it should solve hitslop and double press event on android 👍

yarn add ssh://git@github.com:gorhom/react-native-sticky-item
hirbod commented 4 years ago

Well, a big "dank u" @gorhom. Works perfectly! Now iOS and Android have feature parity :)

gorhom commented 4 years ago

graag gedaan "du bist willkommen", now its release v1.2.1 :)

hirbod commented 4 years ago

PS: your implementation with reanimated is MUCH smoother then facebook's :D (at least on iOS) Facebook feels sloppy and janky

gorhom commented 4 years ago

yeah i notice while i was analysing its animation 😅