search

gorilla-devs / GDLauncher

GDLauncher is a simple, yet powerful Minecraft custom launcher with a strong focus on the user experience
https://gdevs.io
GNU General Public License v3.0
1.22k stars 246 forks source link

Instance installation hangs at "Downloading Mods 0%" #1154

Open faizjamil opened 3 years ago

faizjamil commented 3 years ago

Describe the bug When testing to see if I'm getting that bug where installing Forge hangs, I instead now see that when I am creating an instance of ATM6, it hangs at "Downloading Mods 0%"

To Reproduce Steps to reproduce the behavior:

  1. Get a fresh copy of GDLauncher v 1.1.5
  2. Set it up however you want
  3. Create an instance of ATM6.
  4. Watch it hang at "Downloading Mods 0%"

Expected behavior I expect the mods to be downloaded and the instance to be created.

Possible solutions I can't think of a solution right now, haven't looked through the codebase. However I suggest error handling should be worked on so if some step fails, the instance creation is aborted or at the least, a slightly more descriptive error message than two status codes that are vague (400 or 504, one indicates an error with the request, the other indicates an error from the server).

Actually, now that I'm looking at the error message again, it's making a request to api.gdlauncher.com, which is I assume a Custom API you guys are working on and should be disabled per the changelog, hmm. Screenshots If applicable, add screenshots to help explain your problem.

Operating System:

Additional context

Here's a copy/paste of the last little bit of output on the console

  Patching net/minecraft/util/math/shapes/EntitySelectionContext$1 1/1
index.js:711   Patching net/minecraft/util/math/shapes/EntitySelectionContext 1/1
index.js:711   Patching net/minecraft/tags/TagRegistry$OptionalNamedTag 1/1
index.js:711   Patching net/minecraft/tags/ITagCollectionSupplier$2 1/1
index.js:711   Patching net/minecraft/world/biome/BiomeAmbience$GrassColorModifier$ColorModifier 1/1
api.gdlauncher.com/cf/mods:1 Failed to load resource: the server responded with a status of 400 ()
Error: Request failed with status code 400
    at t.exports (file:///E:/Downloads/GDLauncher-win-portable%20(1)/resources/app.asar/build/static/js/10.4c67e557.chunk.js:2:332249)
    at t.exports (file:///E:/Downloads/GDLauncher-win-portable%20(1)/resources/app.asar/build/static/js/10.4c67e557.chunk.js:2:534552)
    at XMLHttpRequest.d.onreadystatechange (file:///E:/Downloads/GDLauncher-win-portable%20(1)/resources/app.asar/build/static/js/10.4c67e557.chunk.js:2:1179899)
addons-ecs.forgesvc.…6140/file/3358883:1 Failed to load resource: the server responded with a status of 504 ()
createError.js:16 Uncaught (in promise) Error: Request failed with status code 504
    at t.exports (file:///E:/Downloads/GDLauncher-win-portable%20(1)/resources/app.asar/build/static/js/10.4c67e557.chunk.js:2:332249)
    at t.exports (file:///E:/Downloads/GDLauncher-win-portable%20(1)/resources/app.asar/build/static/js/10.4c67e557.chunk.js:2:534552)
    at XMLHttpRequest.d.onreadystatechange (file:///E:/Downloads/GDLauncher-win-portable%20(1)/resources/app.asar/build/static/js/10.4c67e557.chunk.js:2:1179899)
addons-ecs.forgesvc.…1034/file/3390770:1 Failed to load resource: the server responded with a status of 504 ()
addons-ecs.forgesvc.…1430/file/3169106:1 Failed to load resource: the server responded with a status of 504 ()
faizjamil commented 3 years ago

Cloned the repo, started a dev environment, still the same problem.

ZYLHL commented 3 years ago

I meet this problem, too on GD Launcher v1.1.15. Console Error image

Eskaan commented 3 years ago

The original problem is fixed. Code 400 stands for „Bad Request“. Maybe your internet connection or forges server is the problem? (Can you try again, maybe it had an outage)

faizjamil commented 3 years ago

Seems to be fixed now, thanks.

stephen-smith commented 2 years ago

I've getting this same error on at least two modpacks today (Benchmark II and AoF5). The application needs some sort of recovery path when it gets 400 from api.gdlaucher.com/cf/mods

Eskaan commented 2 years ago

Sadly, there is no recovery path to CurseForges API - There is only one and we are doing our best on keeping it working by proxying and caching it on the way to you. Also CurseForge has deprecated their old API so we will have to proxy it whit our API key in the near future anyways because the old API will be taken off.

Eskaan commented 2 years ago

As this issue still persists (And people keep opening new ones) I will see this issue as the first one complaining about the problem. In the mentioned duplicate above you can actually see the Launcher trying to contact our API, failing, and then trying to directly contact the deprecated API. Sadly we can't do really much about this.

Eskaan commented 2 years ago

Another reason for failing API contacts can be an outdated Launcher version and/or a mod that has been taken off the API by the mod Author.

stephen-smith commented 2 years ago

The current behavior is unacceptable. I'm not saying you side step using the CF API, I'm saying "Downloading... 0%" needs to change to "Download Failed. Click to retry." or something to (a) prevent the user from trying to run an incomplete pack and (b) let the user know what is available to do next, even if that is "wait 30 minutes before hammering the CF API again" or "complain to CurseForce on twitter" or something else that isn't an immediate resolution.

I was on 1.1.20, which was the latest one on Flathub, FYI.

IvoryOwl92 commented 2 years ago

I've been having the exact same issue (400 and 504 error code).

Repairing the instance, deleting and starting over, closing GD Launcher and re-opening... I've tried to download two modpacks several times now and nothing fixes it. The only way around it is to download the modpacks as a zip and install them manually, which also means you have repeat the process every time there's an update.

Eskaan commented 2 years ago

It could also be a problem of Mods being taken down form the API. If that is the case here, wie can‘t do anything about it. (EDIT: German spell correction)

Eskaan commented 2 years ago

Note that this issue is just an older type of an issue whit the same orgin - the CurseForge API Failing to answer both our proxy as also directly.

TheButterbrotMan commented 2 years ago

It could also be a problem of Mods bring tanken down form the API. In that is the case therme, wie can‘t do anything about it.

Would it maybe be possible to notify the user, which mods has failed?

blarfoon commented 2 years ago

I think this is an issue on CF's side, I just tried downloading ATM 6 and it worked fine. Don't worry about api.gdlauncher.com failing, that's alright. I agree that we need to change the behavior and it's not the best but I don't have time to refactor or improve it at the moment, I will do it as soon as I can.

pixartist commented 2 years ago

I am having this issue right now.

Afrocntrik commented 2 years ago

Same here right now

NathanDreamweaver commented 2 years ago

Same here, and other launchers and non-launchers (Tested ATLauncher, MultiMC, CMPDL) can download successfully, so it does seem to be a GDLauncher issue

whitewillow commented 2 years ago

Same here right now

Darudas commented 2 years ago

i somehow got it to download even with the same error as mentioned in my issue but now i cant start the pack or rather it crashes on me image

so is there a workaround for the gdlauncher or do i have to use another launcher untill its fixed?

LenoraKestrel commented 2 years ago

Contributing, very sporadic on when it'll resolve itself, consistently errors out and doesn't proceed, but on occasion will "fix" itself and download properly. Went ahead and tried on MultiMC and ran into no issues, as well as that CurseForge app and everything functioned just fine.

That GD Error

Eskaan commented 2 years ago

The problem is the old API we are using. The 400 error is our proxy that has issues. (I don’t have access to it and also know very little Go, which is running on it.) Davide is currently very busy.

toruPuchuu commented 2 years ago

Success (maybe luck?) I experienced this today while trying to install Create: Above and Beyond. On the fourth attempt, once GDLauncher hung on "Downloading 0%", I hit the ">_" in the top left title bar. A few seconds later mods started downloading, and the install successfully finished. FYI, the Developer Tools window says, "". (I use NoScript in FireFox...). It was also the only time I didn't rename the instance.

Windows 10 x64 Pro GDLauncher v1.1.21 (beta channel)

Shoshak commented 2 years ago

Can confirm successful installation 2/3 times. Mods successfully started downloading once i repaired the failed instance of Roguelike Adventures and Dungeons. Had to wait about 2 minutes for it to start, though. The network menu still showed failed (400) request for the proxy, but all the other requests for separate mod info went through. The instance was renamed, btw. Tried installing The Pixelmon Modpack. The process went without hiccups and it started downloading mods immediately. Finished without issues. Installation of ATM6 failed three times in a row, constantly failing with 504 gateway timeout at random mod requests.

Manjaro Linux, v1.1.21

EnigmaticaGH commented 2 years ago

The current behavior is unacceptable. I'm not saying you side step using the CF API, I'm saying "Downloading... 0%" needs to change to "Download Failed. Click to retry." or something to (a) prevent the user from trying to run an incomplete pack and (b) let the user know what is available to do next, even if that is "wait 30 minutes before hammering the CF API again" or "complain to CurseForce on twitter" or something else that isn't an immediate resolution.

I was on 1.1.20, which was the latest one on Flathub, FYI.

100% this. The API failure should fail much more gracefully. If it's occuring because a couple mods in a pack are no longer available through the API, skip to the next mod in the list. When the pack finishes downloading, show a modal popup with mods that failed to download, and their CurseForge URL if possible.

psperneac commented 2 years ago

Here's something that worked for me:

  1. Kill and launch again gdlauncher
  2. Open up the java script dev console before updating the pack ( >_ button top left)
  3. Update the pack
  4. Wait until it gets stuck at 0%
  5. Go to javascript dev console, network tab, sort by status descending, go to top, locate "mods" (should be red, status 504 or 400)
  6. Right click on it in left side list and "Replay XHR". Repeat until it works (you'll see the percentage start to go up in gd launcher window)
wcomartin commented 2 years ago

Another workaround for this is:

Download the Overwolf Curseforge launcher (or any other launcher that supports curse/ftb) Download the pack you want Copy files to Instance Folder in GDLauncher

Eskaan commented 2 years ago

For everyone searching for a temporary fix, please see https://github.com/gorilla-devs/GDLauncher/issues/1266#issuecomment-1026151091

stephen-smith commented 2 years ago

Download the Overwolf Curseforge launcher

Oddly enough, not an option for me. I'm on Debian Linux.

kristu commented 2 years ago

For everyone searching for a temporary fix, please see #1266 (comment)

the problem still persist i'm changing to multimc now because is impossible to download or update any pack :(

faizjamil commented 2 years ago

The issue of not being able to download mods from Curseforge from a non-curseforge launcher isn't unique to GDLauncher. I downloaded ATLaumcher yesterday and encountered a similar issue.

On Sun, Feb 6, 2022, 3:46 AM kristu @.***> wrote:

For everyone searching for a temporary fix, please see #1266 (comment) https://github.com/gorilla-devs/GDLauncher/issues/1266#issuecomment-1026151091

the problem still persist i'm changing to multimc now because is impossible to download any or update any pack :(

— Reply to this email directly, view it on GitHub https://github.com/gorilla-devs/GDLauncher/issues/1154#issuecomment-1030778650, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUCMSUEZRSF3QJWPDZTCLDUZYYPXANCNFSM5HP6LV7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you modified the open/close state.Message ID: @.***>

Ackmard commented 2 years ago

For everyone searching for a temporary fix, please see #1266 (comment)

It Was working for a while but not anymore. Now instead of it being stuck at 0% I get a window that tells me the download failed. image_2022-02-09_170301

Retry does nothing.

Edit: It worked after about 10 times.

Enderlordalatreon commented 2 years ago

For everyone searching for a temporary fix, please see #1266 (comment)

It Was working for a while but not anymore. Now instead of it being stuck at 0% I get a window that tells me the download failed. image_2022-02-09_170301

Retry does nothing.

Edit: It worked after about 10 times.

Didn't work for me unfortunately, still getting that error no matter what.

TNTUP commented 2 years ago

Always having issues with GD lately, can't even install an older modpack I wanted to revisit (FTB Revelation 3.2.0) throws me an error (code 500) about this domain (https://api.gdlauncher.com/cf/fingerprints) idk if its blocked due to my pihole (api.gdlauncher.com works fine so this shouldn't be the cause, tested on VPN same thing)

Pretty annoying the launcher is unstable :/

Froggyysj commented 2 years ago

How get