gorilla-devs / GDLauncher

GDLauncher is a simple, yet powerful Minecraft custom launcher with a strong focus on the user experience
https://gdevs.io
GNU General Public License v3.0
1.22k stars 245 forks source link

Update modpack using zip file #1404

Open abigailwillow opened 2 years ago

abigailwillow commented 2 years ago

Is your feature request related to a problem? Please describe. I've tried managing an unreleased modpack. It is incredibly simple to install as can just import the CurseForge formatted zip file in the "Add New Instance" window, however I cannot update it after that.

Describe the solution you'd like When I right-click my instance and I click manage there is a "Modpack" tab to manage the pack in its entirety on modpacks that were installed via CurseForge or FTB. I would like to see a similar functionality with zip files where I can update the instance by supplying the updated zip file.

Describe alternatives you've considered I have tried clicking the "Check for Updates" button in the "Mods" tab but this only attempts to update the mods, not the modpack. I couldn't find any way to re-import the zip file other than creating a whole new instance. This is bothersome for modpack creation, especially because it wipes my settings every time a new instance is created.

Eskaan commented 2 years ago

Those zip files usually don't contain the Modpack ID, so we can't do anything about it

abigailwillow commented 2 years ago

Those zip files usually don't contain the Modpack ID, so we can't do anything about it

Couldn't the name property in the manifest.json be used as an identifier? Either way the zip contains an overrides folder containing at the very least a mods folder that can be used to update the modpack. Unless I'm misunderstanding the problem, it seems possible to me.

Eskaan commented 2 years ago

Sadly, CF dosen't provide a way of converting slugs to ID's (or something like that, ask @theRookieCoder for more) For most Modpacks updating isn't as easy as upgrading all contained mods. If your issue is that mods imported from a zip aren't detected as CF mods I misunderstood the issue and you can reopen this issue.

DioEgizio commented 2 years ago

Sadly, CF dosen't provide a way of converting slugs to ID's (or something like that, ask @theRookieCoder for more) For most Modpacks updating isn't as easy as upgrading all contained mods. If your issue is that mods imported from a zip aren't detected as CF mods I misunderstood the issue and you can reopen this issue.

Actually, it does in the new api https://docs.curseforge.com/#search-mods in the search route, you can filter by slug

Eskaan commented 2 years ago

Okay, will reopen this then

abigailwillow commented 2 years ago

Additionally, I'd like to add that (in my specific case) the modpack is indeed in CurseForge format however it is not a published pack. I generate my zip file using packwiz.

I could supply an example zip file if you'd like?

theRookieCoder commented 2 years ago

What is the modpack's project ID used for? Ferium just downloads the modpack file, then uses only the file and nothing else to download and install the modpack.

theRookieCoder commented 2 years ago

Additionally, I'd like to add that (in my specific case) the modpack is indeed in CurseForge format however it is not a published pack. I generate my zip file using packwiz.

Interesting, I just created gorilla-devs/ferium#179 so that you can install modpacks from zip files in the future.

XxInvictus commented 1 year ago

I was just looking for this same feature. Some way to be able to maintain an unofficial modpack between friends. My particular problem is some of the mods have Rights Reserved licences so even if I wanted to create the modpack through Curseforge I couldn't.

It would be good to be able to have some way to specify updates for specific mods/versions to their clients without having to do it manually each time. My personal thoughts were some way to add an external link to something like a Onedrive/Dropbox folder/file that way it just gets updated in a single place and they can just "Update the modpack" to get the changes/correct versions.