search

gorilla-devs / GDLauncher

GDLauncher is a simple, yet powerful Minecraft custom launcher with a strong focus on the user experience
https://gdevs.io
GNU General Public License v3.0
1.22k stars 246 forks source link

Trouble when building from source #1573

Closed PassiveLemon closed 11 months ago

PassiveLemon commented 1 year ago

Describe the bug When following the building instructions, running npm run release will give an ENOENT error. To Reproduce

  1. Get the archive
  2. Verify you have the dependencies
  3. Run npm i --legacy-peer-deps
  4. Run npm run release
  5. See error

Expected behavior It finishes building so I can observe the file structure

Possible solutions No clue

Screenshots Full output here: https://pastebin.com/LeKvFuR0

Operating System:

Additional context I am currently working on packing this with Nix to put onto the Nixpkgs repo. I do not know the file structure and where the binary is located after being built so I am building it myself on my host. I believe I have all of the correct dependencies listed. It is an ENOENT spawn error with the 7za module at node_modules/7zip-bin/linux/x64/7za but that does exist at the location. In that log, there also might be other issues I'm not catching lol.

Eskaan commented 1 year ago

Huh, never encountered that before. Could you try running npm install --legacy-peer-deps again and check if a similar path exists?

PassiveLemon commented 1 year ago

I deleted that module, and reran and it does download it. Even made sure that it has execution permissions, which it does. Not sure whats going on

Eskaan commented 1 year ago

So the file exists initially, but get's removed somewhere alsong the build process?

PassiveLemon commented 1 year ago

It seems unlikely to me that it is getting removed as it's still here after the run fails

Eskaan commented 1 year ago

You said " that does exist at the location" so I assumed it did not exist at some point.

PassiveLemon commented 1 year ago

I reran the run command and checked the Last Modification tag which shows the date/time from when I deleted it and reran it earlier

PassiveLemon commented 1 year ago

All I really need is just the file structure after its been built so I know where everything is to package it if you don't mind

Eskaan commented 1 year ago

I think everything you need should be in the deploy folder. But I can't look right now.