gorilla-devs / GDLauncher

GDLauncher is a simple, yet powerful Minecraft custom launcher with a strong focus on the user experience
https://gdevs.io
GNU General Public License v3.0
1.22k stars 245 forks source link

Launcher not recognising prescence of Log4j2 file. #1588

Closed Bw3n15 closed 1 year ago

Bw3n15 commented 1 year ago

I have tried using this fix (the file was already present so I copied it over, deleted the original and made sure to rename correctly): https://github.com/gorilla-devs/GDLauncher/issues/1491#issuecomment-1343431347

The crash occurs when opening a world, it seems to load intially just fine, reaches a "Saving World" screen, it then hangs on the dirtblock background without the text for a few moment before crashing.

Steps to reproduce the behavior:

  1. Create a new 1.19.1 Forge instance on the newest Forge version.
  2. Install the worldedit mod.
  3. Manually install Optifine (including BSL shaders)
  4. Open a world (not sure if happens when creating as I am trying to port over a world I already have)

Expected behavior The world loads and doesn't crash.

Screenshots If applicable, add screenshots to help explain your problem.

I have included both crash reports, one from before I tried the previously mentioned fix and another from after. crash-2023-09-10_19.07.20-client.txt crash-2023-09-10_19.11.25-client.txt

Eskaan commented 1 year ago

Duplicate of https://github.com/gorilla-devs/GDLauncher/issues/1195, it's all a result of the log4shell hotfix. Anyone trying to resolve this would be really appreciated.

Eskaan commented 1 year ago

Actually, it's more likely to not be an issue with Log4J and more with your mod combination (i.e. Optifine)

Bw3n15 commented 1 year ago

Actually, it's more likely to not be an issue with Log4J and more with your mod combination (i.e. Optifine)

i doubt it. its only 2 mods that ive used together before and had no issues with

edit: this issue is resolved now. wasn't a mod combination, i was simply using an incompatible version of forge and optifine.