search

gorilla-devs / GDLauncher

GDLauncher is a simple, yet powerful Minecraft custom launcher with a strong focus on the user experience
https://gdevs.io
GNU General Public License v3.0
1.21k stars 256 forks source link

Modpacks ignore release channel #760

Open Madis0 opened 3 years ago

Madis0 commented 3 years ago

Describe the bug In my modpack, Fabulously Optimized, I currently have 1.16.4 as a stable version and 1.16.5 as a beta one. When searching the name within GDLauncher and clicking Download Latest, it downloads the beta one for some reason, ignoring my "Preferred Curse Release Channel" setting.

To Reproduce Steps to reproduce the behavior:

  1. Open settings (cog)
  2. Make sure Preferred Curse Release Channel is set to Stable
  3. Close settings
  4. Click add (+)
  5. Click Twitch
  6. Search for "Fabulously Optimized"
  7. Click Download Latest
  8. Click next
  9. Wait for download
  10. Right click -> Manage
  11. Note the Curse Modpack section

Expected behavior Should be version 1.4.5 which is the latest stable, not 1.5.0b1 which is the latest beta

Possible solutions Make sure the setting is respected

Screenshots modpack setting

Operating System:

Additional context Doesn't seem to happen with mods.

Eskaan commented 3 years ago

Is this version just named beta something or is it also set as a beta version?

Madis0 commented 3 years ago

It is set as a beta version. So right now 1.9.1 should be preferred for users who select Stable in GDLauncher settings, but instead 2.1.0-beta.3 is downloaded.

image

Eskaan commented 3 years ago

Okay. Could you try if the issue is still persistent in the newer version? I think it could be fixed by now

Madis0 commented 3 years ago

I tried it on v1.1.15-beta.1.

Eskaan commented 3 years ago

hmm. Okay, I will search for it and try to find a fix

Eskaan commented 2 years ago

But still don’t know why exactly it didn’t work :/