search

gorilla-devs / GDLauncher

GDLauncher is a simple, yet powerful Minecraft custom launcher with a strong focus on the user experience
https://gdevs.io
GNU General Public License v3.0
1.21k stars 260 forks source link

support modrinth #768

Open Mari023 opened 3 years ago

Mari023 commented 3 years ago

Is your feature request related to a problem? Please describe. As far as I know, there is currently no launcher which can automatically download mods from modrinth

Describe the solution you'd like allow to download modrinth mods alongside curseforge mods

Describe alternatives you've considered I can't think of one

Additional context I would add a drop down menu to select a modplatform to search mods from, like shown in the screenshot gdlauncher

timelady-victorious commented 3 years ago

Yes i want this to I was just about to ask for this

machinesmith42 commented 3 years ago

how is this?

Ladvace commented 3 years ago

I was working on that but the api were not stable yet, so i'm gonna wait before finishing it

Il mer 10 mar 2021, 02:25 machinesmith42 notifications@github.com ha scritto:

how is this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gorilla-devs/GDLauncher/issues/768#issuecomment-794702765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHO762UFDCBLMPPTBLERA7LTC235XANCNFSM4WQXTSFA .

ghost commented 2 years ago

Status?

Mari023 commented 2 years ago

I was working on that but the api were not stable yet, so i'm gonna wait before finishing it Il mer 10 mar 2021, 02:25 machinesmith42 notifications@github.com ha scritto: … how is this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#768 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHO762UFDCBLMPPTBLERA7LTC235XANCNFSM4WQXTSFA .

to my knowledge, nothing has happened since. I haven't looked at how stable their api is, but I doubt they changed much (at least their documentation hasn't)

zhuher commented 2 years ago

Soooo.... what's up?

blarfoon commented 2 years ago

We decided to not add support for modrinth since it goes against the principles that our open-source community has (me not included). Unless they remove ads from their website apparently we won't add support for it. A different story applies to the new closed-source launcher I am working on which will most likely have support for it. If this is confusing to you don't worry, I'll write something about it soon enough.

ion1 commented 2 years ago

We decided to not add support for modrinth since it goes against the principles that our open-source community has (me not included). Unless they remove ads from their website apparently we won't add support for it.

The GDLauncher website has ads: image

Given that GDLauncher did not previously have a problem the web site for an open source project having ads, what changed if I may ask?

Additionally, GDLauncher currently uses the closed source CurseForge HTTP API to download mods. From what I can tell, both Modrinth code and the code of Ethical Ads (the ad network used by Modrinth) are open source. Supporting Modrinth would only increase the adoption of open source.

A different story applies to the new closed-source launcher I am working on which will most likely have support for it.

I must admit I'm finding it a bit challenging to understand how this resolves the perceived problem of Modrinth not being open source enough by having ads.

I would personally much prefer to continue using an open source launcher, preferably with Modrinth support.

blarfoon commented 2 years ago

The bisecthosting logo is not advertising but it’s a partnership which is different. This was not my decision, from what I understood our community is just completely against advertisements and against any piece of software that has any. This is not actually limited to ads since also a freemium or open core business model were also rejected even though they are officially encouraged by the sustainable free and open source communities (https://sfosc.org/docs/business-models/loose-open-core/). I myself struggle to understand the hate behind any kind of monetisation on my work yet I respect their decision and I decided to continue with another project of my own which I’ll monetise. Adding support for an open source project with monetisation into this project after all the discussions we had would look controversial at best. I don’t feel that my values and ideas are reflected by this community anymore and that’s why I decided to step down, only review prs once a week and start a parallel closed source project after seeing a clear failure in the open source model from my point of view.

cobalt2727 commented 2 years ago

The CurseForge website has ads, though - one popped up at the bottom of the site as soon as I opened it. What makes Modrinth different?

Screenshot_20210726-181234.jpg

blarfoon commented 2 years ago

Alright. I won't be working on adding support for modrith, nonetheless, if someone actually wants to create a PR to add support for it I'll be reviewing it. To be fair, if this project needs to be community-driven, this decision should be too.

zhuher commented 2 years ago

We decided to not add support for modrinth since it goes against the principles that our open-source community has (me not included). Unless they remove ads from their website apparently we won't add support for it.

Damn, that's a whacky community

GlowingUmbreon commented 2 years ago

They have API documentation: https://github.com/modrinth/labrinth/wiki/API-Documentation They also have a library: https://github.com/modrinth/theseus The API documentation seems pretty simple to use so I don't think the library is necessary.

blarfoon commented 2 years ago

Just for completeness, I will be reposting here something I wrote on GDLauncher's discord around 3 months ago (I forgot about it for a while).

I was just extremely angry that a project I worked so hard on doesn't want to give anything back for all the work I put into it but I guess that's just life. That is why I decided not to abandon the project but to not actively develop new features, I will still be reviewing the work from contributors.

I have nothing against modrinth and someone from the GDL team will be adding support for it. I am sorry for what I wrote in this issue it doesn't reflect my thoughts nor my ideas, I was just in a bad state of mind.

jarn123 commented 2 years ago

Don't want to say much but modrinth support will be very handy when the curseforge API sucks

TechPro424 commented 2 years ago

Don't want to say much but modrinth support will be very handy when the curseforge API sucks

Why, what's happening to it?

SlinkousArt commented 2 years ago

Don't want to say much but modrinth support will be very handy when the curseforge API sucks

Why, what's happening to it?

Half of mods aren't able to be downloaded by 3rd party launchers, the API is down every other hour, and it's generally terrible.

rmobis commented 2 years ago

I'm sorry, the whole thread doesn't make it specially clear what is the current situation of this issue, specially given it's quite old. @Eskaan Would you be willing to accept a PR that adds suport for Modrinth?

blarfoon commented 2 years ago

Yes absolutely. If you are interested in helping us with that, please reach out on our discord to me or @Ladvace, he's the one who will work on this, I'm sure he could use some help.

TechPro424 commented 2 years ago

How far has progress on Modrinth support gone? Asking as the issues with CF api are causing me not to be aple to download certain 1.19 mods even though they have a 1.19 version on the CF page Check this GDL Discord thread for a more detailed expleanation of the issue: https://discord.com/channels/398091532881756161/984000419971858432

Eskaan commented 2 years ago

All we have is the Modrinth Modpack pr I think. Edit: #1352

quartzar commented 1 year ago

Status...?

Iris has just been removed from CurseForge... now would be THE time to get on with this.

enhancedrock commented 1 year ago

Any updates?? Plenty of mods like Sodium, Mod Menu and tons of general mods that were on CurseForge but aren't anymore and moved to Modrinth are causing compatibility issues and causing people to manually download the mods themselves, which kinda removes the convenience of having a mod launcher in the first place.

Eskaan commented 1 year ago

This is an open source project, so the general directive for this is DIY. I (sadly) currently don’t have time for this, but I am happy to review any finished pr. You might want to continue on #1322 if you want to work on it.

rmobis commented 1 year ago

@Eskaan So you are accepting contributions? I'm asking for clarification because I made the same question in this issue about a year ago, some of you pointed me to Ladvace on Discord but when I reached out to him I didn't get much more than "we're working on it".

blarfoon commented 1 year ago

This edition of GDLauncher is currently discontinued by our dev team and will soon be replaced by the rewrite of GDL. The old GDL will still be available to the community and this repo will be renamed, but all our development efforts are going towards the rewrite. If you are interested in contributing to the rewrite, we will release the source code of the new repo soon enough, we're currently wrapping up some legal stuff.

If you're instead interested in contributing to this old codebase you're free to do so as well

Eskaan commented 1 year ago

This edition of GDLauncher is currently discontinued by our dev team

Yeah, as he said. I am the only dev currently (working on/)maintaining this, but I don't have much time to develop stuff myself. I am always happy to make a review and I do have the rights to merge and make a new release.

Shibva commented 1 year ago

this divide unforntunaly is going to possibly grow more; I dont know much but from what little I know Curseforge did something that pissed off some people

ranenvious commented 1 year ago

This edition of GDLauncher is currently discontinued by our dev team and will soon be replaced by the rewrite of GDL. The old GDL will still be available to the community and this repo will be renamed, but all our development efforts are going towards the rewrite. If you are interested in contributing to the rewrite, we will release the source code of the new repo soon enough, we're currently wrapping up some legal stuff.

If you're instead interested in contributing to this old codebase you're free to do so as well

As of now is modrinth support planned/in-development for the rewrite? I don't mean to pester on it but as others have mentioned more and more mods are starting to switch to modrinth. I myself have been building out a new pack over the past few days and, whereas in the past modrinth being missing was a bit of an annoyance, I've actually found several mods that just aren't on curseforge at all . It seems like the switch is happening mostly for fabric mods, but a good few forge ones are starting to as well, and Modrinth being missing is starting to cause pretty large problems as more and more mods begin to migrate.

If you don't know I get it, but it's a pretty big feature that has been requested for a while now and it's abscence is starting to rear its head more and more as time goes on, so it seems like something that should be getting at least some love in a rewrite. (although if a rewrite is already in progress it would make sense to not work on ading it to GDLauncher as-is since that's a lot of work for code that's going to most likely become obsolete quite soon, but in the rewrite itself it seems like it should probably take some focus.)

blarfoon commented 1 year ago

Modrinth is definitely getting supported in the rewrite, it's currently planned for phase2, which will happen over the next couple of months. We are currently starting an internal initial test for an MVP version of the launcher, once all the basics are ready we will open a public alpha and start working on adding modrinth support

DovydasTEDS commented 1 year ago

I myself have been building out a new pack over the past few days and, whereas in the past modrinth being missing was a bit of an annoyance, I've actually found several mods that just aren't on curseforge at all . It seems like the switch is happening mostly for fabric mods, but a good few forge ones are starting to as well, and Modrinth being missing is starting to cause pretty large problems as more and more mods begin to migrate.

This is even more true with Sodium not being on CurseForge anymore.

Shibva commented 1 year ago

Even more may move now with the recent attacks on curseforge and buckkt

It's most likely has create a lot of distrust with curse/overwolf management, and bringing their security into question

Andre601 commented 1 year ago

Even more may move now with the recent attacks on curseforge and buckkt

It's most likely has create a lot of distrust with curse/overwolf management, and bringing their security into question

I step in and say that this most likely won't be the case. What happened to curseforge can happen to every page, even Modrinth. In fact, modrinth can be even more dangerous due to its lack of reviews for resource updates, which CF does have.

Also, security can be as safe as possible and still let through malware. How else do you explain Anti-Viruses requiring constant database updates?

Mhowser commented 1 year ago

I think we shouldn't let perfection be the enemy of progress in this case.

MaxLevs commented 1 year ago

Don't want to say much but modrinth support will be very handy when the curseforge API sucks

True. Many mods moved from CF to Modrinth. E.x. Fabric mod menu cf page says that it is outdated and gives new link to modrinth.

TheOverpassArsonist commented 8 months ago

if support does get added, how would GDlauncher handle mods present on both platforms?

Many mods have a version on curseforge that is either unsupported or less supported, and a version on modrinth that gets more frequent updates (or updates at all) along with some mods that just keep a mirror on both sites. For those mods it would be pretty annoying if there are just two distinct entries when you search, so I'm curious if there is a plan on how to address that.

MaxLevs commented 1 month ago

how would GDlauncher handle mods present on both platforms?

I don't think it's a problem. Common practice is to have single repository with sources and configured piplines to build and push artifacts to all desired platforms. And semver is defacto standard of versioning. As result most mods will have identical artifacts names on both platforms.

DovydasTEDS commented 1 month ago

Hello. Please check the new launcher version.

On Tue, 7 May 2024, 15:28 Maxim Liven, @.***> wrote:

how would GDlauncher handle mods present on both platforms?

I don't think it's a problem. Common practice is to have single repository with sources and configured piplines to build and push artifacts to all desired platforms. And semver is defacto standard for versioning. As result most mods will have identical artifacts names on both platforms.

— Reply to this email directly, view it on GitHub https://github.com/gorilla-devs/GDLauncher/issues/768#issuecomment-2098541012, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOUDZAXRSU3BY4TTR53GSQTZBDQHDAVCNFSM4WQXTSFKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBZHA2TIMJQGEZA . You are receiving this because you commented.Message ID: @.***>