search

gorilla-devs / GDLauncher

GDLauncher is a simple, yet powerful Minecraft custom launcher with a strong focus on the user experience
https://gdevs.io
GNU General Public License v3.0
1.22k stars 246 forks source link

Can't quit GDLauncher when it has an update available #934

Open GrumpyChunks opened 3 years ago

GrumpyChunks commented 3 years ago

Describe the bug When the app has an update available, the green icon appears in the titlebar of the application, (which is really neat BTW), however clicking the icon doesn't do a thing on my Linux based system (Pop!_OS 21.04, so it likely affects Ubuntu and other Debian based distros also, though I haven't tested this). There's also an update button that appears in the settings under general category, but this button doesn't do anything either. Whilst this isn't a big deal, as I can easily download and update manually, the main problem is that I can't quit GD Launcher once it's aware it has an update. The close window button doesn't do anything. I can minimise the app, install mod packs, launch instances, I just can't quit GDLauncher.

Note that you can't quit GDLauncher whether you click or don't click the update button.

To quit gdlauncher, I tend to either log off, shutdown or fire up a terminal and issue the command 'pkill gdlauncher'

To Reproduce Steps to reproduce the behavior:

  1. Download GDLauncher from the official website
  2. issue the following commands to install it
    • sudo mkdir /opt/gdlauncher
    • sudo mv GDLauncher-linux-setup.AppImage /opt/gdlauncher/
    • sudo chmod +x /opt/gdlauncher/GDLauncher-linux-setup.AppImage
  3. Fire up GDLauncher (I do this via a .desktop file, but the same behaviour occurs when launched from terminal)
  4. Play Minecraft for some time
  5. Quit Minecraft and GDLauncher
  6. Wait for an update for GDLauncher to be released in fortcoming days/weeks/months (play more Minecraft whilst you wait)
  7. Fire up GDLauncher and see the green icon notifying you that an update is available in the titlebar of the Window
  8. Click on the Close Window icon in the titlebar
  9. GDLauncher doesn't quit

Expected behavior GDLauncher should quit when requested

Possible solutions n/a

Screenshots n/a

Operating System:

Additional context I can't think of anything else useful to provide, though I'm happy to provide any further info on request, or perform any testing suggested by the devs.

Mahlarian commented 3 years ago

I use kubuntu 20.04 (fork of Ubuntu with KDEplasma installed as the desktop environment), can definitely confirm I have this issue as well. I have to right click the program in my tray and then click "Close" in the menu to close it. The X button does nothing and updating doesn't work.