gorilla-devs / ferium

Fast and multi-source CLI program for managing Minecraft mods and modpacks from Modrinth, CurseForge, and GitHub Releases
Mozilla Public License 2.0
1.13k stars 45 forks source link

Dependencies are not resolved recursively #214

Open T3sT3ro opened 1 year ago

T3sT3ro commented 1 year ago

Description

It seems that ferium can't download a required chain of dependencies, and halts at depth 1. So mod A has optional dependency B, while B has required C, but when A prompts to install B as optional, the C is not pulled with B.

To Reproduce

  1. Create test profile for forge 1.16.5
  2. Add "Champions" mod: ferium add 307152
  3. When prompted for optional Craft Tweaker reply n
  4. When prompted for optional Game Stages (268655) reply y
  5. Check out the folder or run ferium list, to see:

    $ ferium list Champions CurseForge 307152 Game Stages CurseForge 268655

  6. Notice, that Game Stages requires Bookshelf (228525), but it was not downloaded.

manually removing GameStages and adding them via ferium add 268655 pulls the required Bookself properly

Software version

Additional information

It seems like ferium cannot recursively resolve dependencies.

Potential or ad-hoc sollutions and considerations

Boobies commented 4 months ago

I would suggest expediting this ticket - not in an entitled way, obviously this isn't a day job, but in the sense that it should be given top priority over the other open issues. This is a particularly important features without which managing large collections of mods becomes a lot more impractical.